From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 1C2CE6DE0BF6 for ; Thu, 17 Aug 2017 10:54:30 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.066 X-Spam-Level: X-Spam-Status: No, score=-0.066 tagged_above=-999 required=5 tests=[AWL=-0.105, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.211, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Tz1B7x2jm3o for ; Thu, 17 Aug 2017 10:54:27 -0700 (PDT) Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com [209.85.128.176]) by arlo.cworth.org (Postfix) with ESMTPS id 0D8976DE0350 for ; Thu, 17 Aug 2017 10:54:23 -0700 (PDT) Received: by mail-wr0-f176.google.com with SMTP id b65so50400002wrd.0 for ; Thu, 17 Aug 2017 10:54:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aFRPMiMEcZmUBRo3GSlAGWzJt1Rc6tBCbQcr/AXf5+U=; b=cxHbWVgd7zIibpqghTzhlSuKVL1WekAjdOvrWeV4HGUdjxxsGt9RtUTEx7IhhUHz78 zffnX9MyJW+YifBse1uFHRV7INW5IkcYpy8vEUFVglwW/OwX9uQGOCmNo4SnDcKz9+T/ JCepq9p5zeoj4u3Q+1134xH6KYh+PZtdgdoitPu+fvSipWanLgjtoDFlG8qZPR/l5ZIT 9icv3wQIQeE1E54ETErwR+JlpNZQLFDjBT43A5kFNxs3aaHshpnCYdwrxgj5Yq6n8VGe +3h2IMEI0fU93gfVWF3mEMKfg1T/qKNnK7A0I72a/0kmiPvg1vB8hqBfZyb8jAAI5jZu 9GPQ== X-Gm-Message-State: AHYfb5i7EW6pUYeI/IgkelnafnRfuBdMuZqaEkDx4RiaCNK+EhWagfS2 yUqMjs8SPZfiLkwMrw0= X-Received: by 10.28.189.68 with SMTP id n65mr1937258wmf.15.1502992461479; Thu, 17 Aug 2017 10:54:21 -0700 (PDT) Received: from home.thecybershadow.net ([89.28.117.31]) by smtp.gmail.com with ESMTPSA id c34sm4345025wra.80.2017.08.17.10.54.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Aug 2017 10:54:20 -0700 (PDT) From: Vladimir Panteleev To: notmuch@notmuchmail.org Subject: [PATCH 4/7] test: Fix T050-new.sh on some Travis CI machines Date: Thu, 17 Aug 2017 17:51:42 +0000 Message-Id: <20170817175145.3204-5-notmuch@thecybershadow.net> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170817175145.3204-1-notmuch@thecybershadow.net> References: <20170817175145.3204-1-notmuch@thecybershadow.net> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Aug 2017 17:54:30 -0000 On some system configurations, setting a breakpoint on the "add_file" function then issuing "continue" in gdb causes the debugger to seemingly jump over the add_file invocation. This results in a test failure, as the "Handle files vanishing between scandir and add_file" subtest expects add_file to be called and fail due to the vanishing file. The compiler optimization level also plays a role - the problem can be reproduced with CFLAGS having -O2 but not -Og. This problem was observed manifesting as a test failure on Travis CI configured with "dist: trusty" and "sudo: false". It was not reproducible on a local Docker image of Travis' runtime environment, so Travis' virtualization infrastructure likely plays a role as well. * T050-new.sh: Breakpoint notmuch_database_add_message instead of add_file to the same effect, and avoid bad gdb behaviour on Travis CI. --- test/T050-new.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/T050-new.sh b/test/T050-new.sh index ffa303ef..8b7ac4e1 100755 --- a/test/T050-new.sh +++ b/test/T050-new.sh @@ -309,7 +309,7 @@ cat < notmuch-new-vanish.gdb set breakpoint pending on set logging file notmuch-new-vanish-gdb.log set logging on -break add_file +break notmuch_database_add_message commands shell rm -f ${MAIL_DIR}/vanish continue -- 2.13.3