From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCH] Avoid crashes in "notmuch reply" with gmime 3.0 when reply-to == sender
Date: Sat, 15 Jul 2017 00:03:35 +0200 [thread overview]
Message-ID: <20170714220335.17884-1-dkg@fifthhorseman.net> (raw)
In-Reply-To: <20170714201423.19688-2-dkg@fifthhorseman.net>
Bremner found this fix. I'm just documenting it for posterity :)
---
notmuch-reply.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/notmuch-reply.c b/notmuch-reply.c
index bb6b99fa..4f3f3859 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -286,7 +286,7 @@ static InternetAddressList *get_sender(GMimeMessage *message)
if (! reply_to_header_is_redundant (message, reply_to_list))
return reply_to_list;
- g_object_unref (G_OBJECT (reply_to_list));
+ g_mime_2_6_unref (G_OBJECT (reply_to_list));
}
return g_mime_message_get_from (message);
--
2.13.2
next prev parent reply other threads:[~2017-07-14 22:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 13:09 [PATCH 1/2] Ensure that "notmuch reply" succeeds during testing Daniel Kahn Gillmor
2017-07-14 13:09 ` [PATCH 2/2] Add additional munged reply-to tests Daniel Kahn Gillmor
2017-07-14 13:26 ` Daniel Kahn Gillmor
2017-07-14 14:42 ` [PATCH 1/2] Ensure that "notmuch reply" succeeds during testing David Bremner
2017-07-14 17:08 ` Daniel Kahn Gillmor
2017-07-14 18:04 ` David Bremner
2017-07-14 20:14 ` [PATCH v2 " Daniel Kahn Gillmor
2017-07-14 20:14 ` [PATCH v2 2/2] Add additional munged reply-to tests Daniel Kahn Gillmor
2017-07-14 22:03 ` Daniel Kahn Gillmor [this message]
2017-07-14 22:13 ` [PATCH] Avoid crashes in "notmuch reply" with gmime 3.0 when reply-to == sender Daniel Kahn Gillmor
2017-07-14 22:53 ` Daniel Kahn Gillmor
2017-07-15 11:47 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714220335.17884-1-dkg@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).