From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 226D56DE2E03 for ; Fri, 14 Jul 2017 15:03:44 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.000] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DEwhkE-hPevy for ; Fri, 14 Jul 2017 15:03:43 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTP id 4182D6DE2DFB for ; Fri, 14 Jul 2017 15:03:43 -0700 (PDT) Received: from fifthhorseman.net (38.200.broadband6.iol.cz [88.101.200.38]) by che.mayfirst.org (Postfix) with ESMTPSA id B69E3F99D for ; Fri, 14 Jul 2017 18:03:39 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id AD9062018B; Sat, 15 Jul 2017 00:03:35 +0200 (CEST) From: Daniel Kahn Gillmor To: Notmuch Mail Subject: [PATCH] Avoid crashes in "notmuch reply" with gmime 3.0 when reply-to == sender Date: Sat, 15 Jul 2017 00:03:35 +0200 Message-Id: <20170714220335.17884-1-dkg@fifthhorseman.net> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170714201423.19688-2-dkg@fifthhorseman.net> References: <20170714201423.19688-2-dkg@fifthhorseman.net> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 22:03:44 -0000 Bremner found this fix. I'm just documenting it for posterity :) --- notmuch-reply.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index bb6b99fa..4f3f3859 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -286,7 +286,7 @@ static InternetAddressList *get_sender(GMimeMessage *message) if (! reply_to_header_is_redundant (message, reply_to_list)) return reply_to_list; - g_object_unref (G_OBJECT (reply_to_list)); + g_mime_2_6_unref (G_OBJECT (reply_to_list)); } return g_mime_message_get_from (message); -- 2.13.2