* [PATCH] Makefile.local: have all files in release tarball be owned by root
@ 2017-04-08 19:00 Tomi Ollila
2017-05-07 11:57 ` David Bremner
0 siblings, 1 reply; 2+ messages in thread
From: Tomi Ollila @ 2017-04-08 19:00 UTC (permalink / raw)
To: notmuch; +Cc: tomi.ollila
The tar content `git archive` creates (reproducibly) have owner and
group set to 'root'. (GNU) tar writes user ids to the added file
`version` by default. The contents of tar archive looks better and
more consistent when owner and group in all files are the same.
While at it, split this long command line to multiple lines.
---
Tested with make notmuch-0.24.1+63~g9338dda.tar.gz -- YMMV.
Makefile.local | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Makefile.local b/Makefile.local
index 03eafaa..3d3474e 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -31,7 +31,9 @@ $(TAR_FILE):
fi ; \
git archive --format=tar --prefix=$(PACKAGE)-$(VERSION)/ $$ref > $(TAR_FILE).tmp
echo $(VERSION) > version.tmp
- tar --append -f $(TAR_FILE).tmp --transform s_^_$(PACKAGE)-$(VERSION)/_ --transform 's_.tmp$$__' version.tmp
+ tar --owner root --group root --append -f $(TAR_FILE).tmp \
+ --transform s_^_$(PACKAGE)-$(VERSION)/_ \
+ --transform 's_.tmp$$__' version.tmp
rm version.tmp
gzip < $(TAR_FILE).tmp > $(TAR_FILE)
@echo "Source is ready for release in $(TAR_FILE)"
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Makefile.local: have all files in release tarball be owned by root
2017-04-08 19:00 [PATCH] Makefile.local: have all files in release tarball be owned by root Tomi Ollila
@ 2017-05-07 11:57 ` David Bremner
0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2017-05-07 11:57 UTC (permalink / raw)
To: Tomi Ollila, notmuch; +Cc: tomi.ollila, notmuch
Tomi Ollila <tomi.ollila@iki.fi> writes:
> The tar content `git archive` creates (reproducibly) have owner and
> group set to 'root'. (GNU) tar writes user ids to the added file
> `version` by default. The contents of tar archive looks better and
> more consistent when owner and group in all files are the same.
>
> While at it, split this long command line to multiple lines.
pushed to master (some time ago)
d
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-07 11:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-08 19:00 [PATCH] Makefile.local: have all files in release tarball be owned by root Tomi Ollila
2017-05-07 11:57 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).