From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [PATCH 4/6] cli/show: fix some memory leaks in format_part_text
Date: Sat, 18 Mar 2017 14:50:36 -0300 [thread overview]
Message-ID: <20170318175038.15887-5-david@tethera.net> (raw)
In-Reply-To: <20170318175038.15887-1-david@tethera.net>
Mimic Jeff Stedfast's changes to format_headers_sprinter, clean up use
of internet_address_list_to_string and
g_mime_message_get_date_as_string.
---
notmuch-show.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
index 095595e2..b0afc29e 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -460,7 +460,8 @@ format_part_text (const void *ctx, sprinter_t *sp, mime_node_t *node,
if (GMIME_IS_MESSAGE (node->part)) {
GMimeMessage *message = GMIME_MESSAGE (node->part);
InternetAddressList *recipients;
- const char *recipients_string;
+ char *recipients_string;
+ char *date_string;
printf ("\fheader{\n");
if (node->envelope_file)
@@ -471,11 +472,15 @@ format_part_text (const void *ctx, sprinter_t *sp, mime_node_t *node,
recipients_string = internet_address_list_to_string (recipients, 0);
if (recipients_string)
printf ("To: %s\n", recipients_string);
+ g_free (recipients_string);
recipients = g_mime_message_get_recipients (message, GMIME_RECIPIENT_TYPE_CC);
recipients_string = internet_address_list_to_string (recipients, 0);
if (recipients_string)
printf ("Cc: %s\n", recipients_string);
- printf ("Date: %s\n", g_mime_message_get_date_as_string (message));
+ g_free (recipients_string);
+ date_string = g_mime_message_get_date_as_string (message);
+ printf ("Date: %s\n", date_string);
+ g_free (date_string);
printf ("\fheader}\n");
printf ("\fbody{\n");
--
2.11.0
next prev parent reply other threads:[~2017-03-18 17:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 17:50 memory leak cleanup for notmuch show David Bremner
2017-03-18 17:50 ` [PATCH 1/6] perf-test: use 'eval' in memory_run David Bremner
2017-03-18 21:04 ` Tomi Ollila
2017-03-18 17:50 ` [PATCH 2/6] perf-test: add simple memory tests for notmuch-show David Bremner
2017-03-18 17:50 ` [PATCH 3/6] fix memory leaks in notmuch-show.c:format_headers_sprinter() David Bremner
2017-03-18 17:50 ` David Bremner [this message]
2017-03-18 17:50 ` [PATCH 5/6] cli/show: fix usage of g_mime_content_type_to_string David Bremner
2017-03-18 17:50 ` [PATCH 6/6] cli/show: unref crlf filter David Bremner
2017-03-18 20:03 ` [PATCH] perf-test/mem: add simple memory tests for notmuch search David Bremner
2017-03-18 21:11 ` memory leak cleanup for notmuch show Tomi Ollila
2017-03-19 0:14 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170318175038.15887-5-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).