From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id D6DDC6DE16A4 for ; Sat, 18 Mar 2017 10:50:51 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.005 X-Spam-Level: X-Spam-Status: No, score=-0.005 tagged_above=-999 required=5 tests=[AWL=0.006, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DUGovMrGhE5w for ; Sat, 18 Mar 2017 10:50:51 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id B3E206DE169D for ; Sat, 18 Mar 2017 10:50:50 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1cpIUR-0001Oz-O6; Sat, 18 Mar 2017 13:50:07 -0400 Received: (nullmailer pid 15963 invoked by uid 1000); Sat, 18 Mar 2017 17:50:46 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: [PATCH 4/6] cli/show: fix some memory leaks in format_part_text Date: Sat, 18 Mar 2017 14:50:36 -0300 Message-Id: <20170318175038.15887-5-david@tethera.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170318175038.15887-1-david@tethera.net> References: <20170318175038.15887-1-david@tethera.net> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Mar 2017 17:50:51 -0000 Mimic Jeff Stedfast's changes to format_headers_sprinter, clean up use of internet_address_list_to_string and g_mime_message_get_date_as_string. --- notmuch-show.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 095595e2..b0afc29e 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -460,7 +460,8 @@ format_part_text (const void *ctx, sprinter_t *sp, mime_node_t *node, if (GMIME_IS_MESSAGE (node->part)) { GMimeMessage *message = GMIME_MESSAGE (node->part); InternetAddressList *recipients; - const char *recipients_string; + char *recipients_string; + char *date_string; printf ("\fheader{\n"); if (node->envelope_file) @@ -471,11 +472,15 @@ format_part_text (const void *ctx, sprinter_t *sp, mime_node_t *node, recipients_string = internet_address_list_to_string (recipients, 0); if (recipients_string) printf ("To: %s\n", recipients_string); + g_free (recipients_string); recipients = g_mime_message_get_recipients (message, GMIME_RECIPIENT_TYPE_CC); recipients_string = internet_address_list_to_string (recipients, 0); if (recipients_string) printf ("Cc: %s\n", recipients_string); - printf ("Date: %s\n", g_mime_message_get_date_as_string (message)); + g_free (recipients_string); + date_string = g_mime_message_get_date_as_string (message); + printf ("Date: %s\n", date_string); + g_free (date_string); printf ("\fheader}\n"); printf ("\fbody{\n"); -- 2.11.0