From: Austin Clements <amdragon@MIT.EDU>
To: Michal Nazarewicz <mpn@google.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: notmuch-search: fix faces
Date: Mon, 27 Aug 2012 22:19:17 -0400 [thread overview]
Message-ID: <20120828021917.GC11179@mit.edu> (raw)
In-Reply-To: <xa1twr0ju9cq.fsf@mina86.com>
Quoth Michal Nazarewicz on Aug 28 at 2:51 am:
> > Quoth Michal Nazarewicz on Aug 28 at 1:11 am:
> >> I'm not an expert either, but with this patch applied I see colours,
> >> without this patch, I don't see colours, ie. everything is rendered
> >> using the default face.
> >>
> >> I'm also not entirely sure if that's the correct way of doing things
> >> since 'face seems to be working in other modes (most notably
> >> notmuch-show). By posting, I'm also hoping that someone more
> >> experienced will maybe take a look to see what's going on here... ;)
> >>
> >> For some more info, in notmuch-show mode, I get-text-property of nil for
> >> both 'face and 'font-lock-face, but in message-mode or in *scratch*
> >> buffer I'm getting nil for 'font-lock-face but non-nil for 'face. With
> >> the patch, I'm getting the same non-nil for both 'face and
> >> 'font-lock-face; without the patch, I'm getting nil for both.
>
> Austin Clements <amdragon@MIT.EDU> writes:
> > This is odd. Could you give more details about your environment? In
> > particular, what Emacs version are you running and might you have any
> > unusual Emacs packages installed or customizations set?
>
> I'm running Emacs compiled from a week old bzr head, emacs-version
> reports: “GNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu) of 2012-08-21
> on mpn-glaptop”.
>
> I don't think I have any “unusual” packages, but I do have quite a bit
> of customization, which you might find at
> <https://github.com/mina86/dot-files/blob/master/dot-emacs>.
I think the culprit is your "Show blanks and FIXME"
font-lock-mode-hook.
> > The unusual thing about font-lock-face is that it only gets applied if
> > font-lock is enabled; otherwise it's ignored. One theory is that the
> > nil font-lock-face (without your patch) is causing font-lock to
> > *override* the face property that we set. I don't think font-lock
> > usually does that, but perhaps in some situations, it will?
>
> Ha! That could be the cause. I've disabled global-font-lock-mode, and
> the colours appeared. Getting property returns non-nil for 'face and
> nil for 'font-lock-face. When I enable font-lock-mode the property seem
> to disappear and disabling font-lock-mode again does not help.
It's possible we should use font-lock-face. I'm not sure. Poking
around the standard elisp, it looks like some things use 'face and
some things use 'font-lock-face. I think 'face is more common, but
it's hard to grep for.
next prev parent reply other threads:[~2012-08-28 2:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 12:59 [PATCH] emacs: notmuch-search: fix faces Michal Nazarewicz
2012-08-27 20:40 ` Jameson Graef Rollins
2012-08-27 23:11 ` Michal Nazarewicz
2012-08-28 0:22 ` Austin Clements
2012-08-28 0:51 ` Michal Nazarewicz
2012-08-28 2:19 ` Austin Clements [this message]
2012-08-28 12:58 ` Michal Nazarewicz
2012-08-30 8:18 ` Tomi Ollila
2012-09-03 12:18 ` Michal Nazarewicz
2012-09-05 23:43 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120828021917.GC11179@mit.edu \
--to=amdragon@mit.edu \
--cc=mpn@google.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).