From: Austin Clements <amdragon@MIT.EDU>
To: Michal Nazarewicz <mpn@google.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: notmuch-search: fix faces
Date: Mon, 27 Aug 2012 20:22:15 -0400 [thread overview]
Message-ID: <20120828002215.GB11179@mit.edu> (raw)
In-Reply-To: <xa1t3938ue0m.fsf@mina86.com>
Quoth Michal Nazarewicz on Aug 28 at 1:11 am:
> > On Thu, Aug 23 2012, Michal Nazarewicz <mpn@google.com> wrote:
> >> For some reason the faces do not get applied when 'face property is
> >> used, but they work correctly with 'font-lock-face property. This
> >> commit changes notmuch-search to use the latter.
>
> Jameson Graef Rollins <jrollins@finestructure.net> writes:
> > Hi, Michal. Can you say a bit more about what's motivating this? This
> > feature seems to work fine for me, so I would like to understand what's
> > not working for you. I'm certainly no expert on emacs font handling,
> > though, so maybe this is the proper thing to do. Thanks.
>
> I'm not an expert either, but with this patch applied I see colours,
> without this patch, I don't see colours, ie. everything is rendered
> using the default face.
>
> I'm also not entirely sure if that's the correct way of doing things
> since 'face seems to be working in other modes (most notably
> notmuch-show). By posting, I'm also hoping that someone more
> experienced will maybe take a look to see what's going on here... ;)
>
> For some more info, in notmuch-show mode, I get-text-property of nil for
> both 'face and 'font-lock-face, but in message-mode or in *scratch*
> buffer I'm getting nil for 'font-lock-face but non-nil for 'face. With
> the patch, I'm getting the same non-nil for both 'face and
> 'font-lock-face; without the patch, I'm getting nil for both.
This is odd. Could you give more details about your environment? In
particular, what Emacs version are you running and might you have any
unusual Emacs packages installed or customizations set?
The unusual thing about font-lock-face is that it only gets applied if
font-lock is enabled; otherwise it's ignored. One theory is that the
nil font-lock-face (without your patch) is causing font-lock to
*override* the face property that we set. I don't think font-lock
usually does that, but perhaps in some situations, it will?
next prev parent reply other threads:[~2012-08-28 0:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 12:59 [PATCH] emacs: notmuch-search: fix faces Michal Nazarewicz
2012-08-27 20:40 ` Jameson Graef Rollins
2012-08-27 23:11 ` Michal Nazarewicz
2012-08-28 0:22 ` Austin Clements [this message]
2012-08-28 0:51 ` Michal Nazarewicz
2012-08-28 2:19 ` Austin Clements
2012-08-28 12:58 ` Michal Nazarewicz
2012-08-30 8:18 ` Tomi Ollila
2012-09-03 12:18 ` Michal Nazarewicz
2012-09-05 23:43 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120828002215.GB11179@mit.edu \
--to=amdragon@mit.edu \
--cc=mpn@google.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).