From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [Patch v2 0/3] Add test and fix exclude bug
Date: Thu, 15 Mar 2012 23:33:56 -0400 [thread overview]
Message-ID: <20120316033356.GE2670@mit.edu> (raw)
In-Reply-To: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com>
Quoth Mark Walters on Mar 14 at 12:26 pm:
> The test in the previous patches
> id:"1331551914-28323-1-git-send-email-markwalters1009@gmail.com"
> triggered the bug accidentally. It accidentally set the exclude tags
> to be "=" and "deleted" rather than just "deleted". The non-existent
> "=" tag (i.e., the tag that does not occur anywhere in the Xapian
> database) triggered the bug. First we correct the tests to just set
> the "deleted" tag, then we add some tests including one with a
> deliberately non-existent tag. Finally, we modify the exclusion code
> to avoid the bug.
>
> The modification also appears to fix a similar problem for jrollins
> that I have not yet been able to reproduce.
>
> Since the code is now more clearly correct, cleaner and we do
> definitely avoid a Xapian bug I think these patches can be committed
> even without knowing why it fixed jrollins' bug.
>
> Finally these apply to current master (not to the --with-excluded series).
LGTM. It would be nice to have the broken tests marked broken in the
patch that introduces them, but it's fine.
next prev parent reply other threads:[~2012-03-16 3:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 12:26 [Patch v2 0/3] Add test and fix exclude bug Mark Walters
2012-03-14 12:26 ` [Patch v2 1/3] test: the test for the exclude code mistakenly excludes the tag "=" Mark Walters
2012-03-14 12:26 ` [Patch v2 2/3] test: add tests for message only search Mark Walters
2012-03-14 12:26 ` [Patch v2 3/3] lib: fix an exclude bug Mark Walters
2012-03-16 3:33 ` Austin Clements [this message]
2012-03-17 6:02 ` [Patch v2 0/3] Add test and fix " Jameson Graef Rollins
2012-03-18 12:43 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316033356.GE2670@mit.edu \
--to=amdragon@mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).