From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 50926431FAF for ; Thu, 15 Mar 2012 20:34:00 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5Ssw3vKYHlUj for ; Thu, 15 Mar 2012 20:33:59 -0700 (PDT) Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU [18.9.25.15]) by olra.theworths.org (Postfix) with ESMTP id CCA8B431FAE for ; Thu, 15 Mar 2012 20:33:59 -0700 (PDT) X-AuditID: 1209190f-b7f8a6d000000914-f4-4f62b4a53406 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP id 52.98.02324.5A4B26F4; Thu, 15 Mar 2012 23:33:57 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q2G3XvRJ006500; Thu, 15 Mar 2012 23:33:57 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2G3XumX029383 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Thu, 15 Mar 2012 23:33:56 -0400 (EDT) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1S8NvQ-0002FS-1x; Thu, 15 Mar 2012 23:33:56 -0400 Date: Thu, 15 Mar 2012 23:33:56 -0400 From: Austin Clements To: Mark Walters Subject: Re: [Patch v2 0/3] Add test and fix exclude bug Message-ID: <20120316033356.GE2670@mit.edu> References: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnleLIzCtJLcpLzFFi42IRYrdT0V26Jcnf4PZSE4vVc3ksrt+cyezA 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZXTsmMFScIGjomXTH/YGxh9sXYycHBICJhLn n95mh7DFJC7cWw8U5+IQEtjHKPFl+20oZwOjxJQZE5khnJNMEiuv3oXKLGGU2D21iwmkn0VA VeLurw5GEJtNQENi2/7lYLaIgI7E7UMLwHYwC0hLfPvdDFYvLGAhsfP3QbAaXgFtiSUtJ5hB bCEBT4k/D6axQsQFJU7OfMIC0aslcePfS6BeDrA5y/9xgIQ5BbwkHjSuAysXFVCRmHJyG9sE RqFZSLpnIemehdC9gJF5FaNsSm6Vbm5iZk5xarJucXJiXl5qka6JXm5miV5qSukmRlBYc0ry 72D8dlDpEKMAB6MSD+9K/iR/IdbEsuLK3EOMkhxMSqK8RsuAQnxJ+SmVGYnFGfFFpTmpxYcY JTiYlUR4MwwS/YV4UxIrq1KL8mFS0hwsSuK8alrv/IQE0hNLUrNTUwtSi2CyMhwcShK8YsD4 FRIsSk1PrUjLzClBSDNxcIIM5wEa/mozUA1vcUFibnFmOkT+FKMuR/fUR5cYhVjy8vNSpcR5 34AUCYAUZZTmwc2BpaNXjOJAbwnz/gKp4gGmMrhJr4CWMAEtKfkWB7KkJBEhJdXAGLRKrHS/ 82YtVa7UfOU1H7xcH74U+LslT9Tq4DVtE2/OvYei3sYbpe/5ZHf5+0PPnUI7C7hZ+pfc5In4 bxq3J2WJvpVAtfTL9EuC3d9Pr2j36dhZMKF8NYPbulWnpA9U5xWt/bPxATfT3rlvPXKmlO2t e23xZerBA9MPJe2s7v+zcmr43QSfK0osxRmJhlrMRcWJADUmDqwiAwAA Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2012 03:34:00 -0000 Quoth Mark Walters on Mar 14 at 12:26 pm: > The test in the previous patches > id:"1331551914-28323-1-git-send-email-markwalters1009@gmail.com" > triggered the bug accidentally. It accidentally set the exclude tags > to be "=" and "deleted" rather than just "deleted". The non-existent > "=" tag (i.e., the tag that does not occur anywhere in the Xapian > database) triggered the bug. First we correct the tests to just set > the "deleted" tag, then we add some tests including one with a > deliberately non-existent tag. Finally, we modify the exclusion code > to avoid the bug. > > The modification also appears to fix a similar problem for jrollins > that I have not yet been able to reproduce. > > Since the code is now more clearly correct, cleaner and we do > definitely avoid a Xapian bug I think these patches can be committed > even without knowing why it fixed jrollins' bug. > > Finally these apply to current master (not to the --with-excluded series). LGTM. It would be nice to have the broken tests marked broken in the patch that introduces them, but it's fine.