[PATCH] configure: use cc/c++ when GCC not installed

[PATCH] configure: use cc/c++ when GCC not installed

[Fraser Tweedale]

Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler
Collection.  Use generic cc/c++ as a fallback when gcc/g++ are not
available.
---
 configure | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 9bde2eb..3f4942b 100755
--- a/configure
+++ b/configure
@@ -43,8 +43,16 @@ fi
 
 # Set several defaults (optionally specified by the user in
 # environment variables)
-CC=${CC:-gcc}
-CXX=${CXX:-g++}
+if which gcc >/dev/null 2>&1; then
+    CC=${CC:-gcc}
+else
+    CC=${CC:-cc}
+fi
+if which g++ >/dev/null 2>&1; then
+    CXX=${CXX:-g++}
+else
+    CXX=${CXX:-c++}
+fi
 CFLAGS=${CFLAGS:--O2}
 CPPFLAGS=${CPPFLAGS:-}
 CXXFLAGS=${CXXFLAGS:-\$(CFLAGS)}
-- 
1.9.2

Re: [PATCH] configure: use cc/c++ when GCC not installed

[Tomi Ollila]

On Wed, May 21 2014, Fraser Tweedale <frase@frase.id.au> wrote:

> Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler
> Collection.  Use generic cc/c++ as a fallback when gcc/g++ are not
> available.
> ---
>  configure | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 9bde2eb..3f4942b 100755
> --- a/configure
> +++ b/configure
> @@ -43,8 +43,16 @@ fi
>  
>  # Set several defaults (optionally specified by the user in
>  # environment variables)
> -CC=${CC:-gcc}
> -CXX=${CXX:-g++}
> +if which gcc >/dev/null 2>&1; then
> +    CC=${CC:-gcc}
> +else
> +    CC=${CC:-cc}
> +fi

perhaps:

if [ -z "$CC" ]; then
   if hash gcc 2>/dev/null; then
   	CC=gcc
   else 
   	CC=cc
   fi
fi

and same for g++

hash is builtin in modern shells, and is command in some systems
which(1) is builtin in zsh (only?). Solaris 10 which(1) exits 0
even the command is not found.

Tomi


> +if which g++ >/dev/null 2>&1; then
> +    CXX=${CXX:-g++}
> +else
> +    CXX=${CXX:-c++}
> +fi
>  CFLAGS=${CFLAGS:--O2}
>  CPPFLAGS=${CPPFLAGS:-}
>  CXXFLAGS=${CXXFLAGS:-\$(CFLAGS)}
> -- 
> 1.9.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] configure: use cc/c++ when GCC not installed

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:
>
> hash is builtin in modern shells, and is command in some systems
> which(1) is builtin in zsh (only?). Solaris 10 which(1) exits 0
> even the command is not found.
>
> Tomi

I thought "command -v" was the posix way of testing for a binary?

d

Re: [PATCH] configure: use cc/c++ when GCC not installed

[Tomi Ollila]

On Wed, May 21 2014, David Bremner <david@tethera.net> wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>>
>> hash is builtin in modern shells, and is command in some systems
>> which(1) is builtin in zsh (only?). Solaris 10 which(1) exits 0
>> even the command is not found.
>>
>> Tomi
>
> I thought "command -v" was the posix way of testing for a binary?


Ok, I wrote quite a few lines why hash instead of command -v,
just to finally notice this:

$ dash -c 'hash zapdsb || echo foo'
dash: 1: hash: zapdsb : not found
foo

which is ok... but:

$ ksh -c 'hash zapdsb || echo foo'
$ mksh -c 'hash zapdsb || echo foo'

Wat! hash in these shells do not exit nonzero -- so good with my which(1)
rant >;/

So I change my preference totally -- `command -v` instead of `hash` -- we
have to fix the current uses of `hash` too...


> d


Tomi

RE: [PATCH] configure: use cc/c++ when GCC not installed

[Felipe Contreras]

Fraser Tweedale wrote:
> Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler
> Collection.  Use generic cc/c++ as a fallback when gcc/g++ are not
> available.
> ---
>  configure | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 9bde2eb..3f4942b 100755
> --- a/configure
> +++ b/configure
> @@ -43,8 +43,16 @@ fi
>  
>  # Set several defaults (optionally specified by the user in
>  # environment variables)
> -CC=${CC:-gcc}
> -CXX=${CXX:-g++}

Why not just use cc and c++?

-- 
Felipe Contreras

Re: [PATCH] configure: use cc/c++ when GCC not installed

[Fraser Tweedale]

On Wed, May 21, 2014 at 10:49:03PM -0500, Felipe Contreras wrote:
> Fraser Tweedale wrote:
> > Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler
> > Collection.  Use generic cc/c++ as a fallback when gcc/g++ are not
> > available.
> > ---
> >  configure | 12 ++++++++++--
> >  1 file changed, 10 insertions(+), 2 deletions(-)
> > 
> > diff --git a/configure b/configure
> > index 9bde2eb..3f4942b 100755
> > --- a/configure
> > +++ b/configure
> > @@ -43,8 +43,16 @@ fi
> >  
> >  # Set several defaults (optionally specified by the user in
> >  # environment variables)
> > -CC=${CC:-gcc}
> > -CXX=${CXX:-g++}
> 
> Why not just use cc and c++?
 
I intended to change the behaviour as little as possible, however,
if you and others are satisfied to simply use cc/c++ then I will
make it so.

> -- 
> Felipe Contreras

[PATCH v2] configure: use cc/c++ instead of gcc/g++

[Fraser Tweedale]

Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler
Collection.  Use generic cc/c++ instead of gcc/g++ (unless the
CC/CXX environment variables are used).
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 9bde2eb..7d015c6 100755
--- a/configure
+++ b/configure
@@ -43,8 +43,8 @@ fi
 
 # Set several defaults (optionally specified by the user in
 # environment variables)
-CC=${CC:-gcc}
-CXX=${CXX:-g++}
+CC=${CC:-cc}
+CXX=${CXX:-c++}
 CFLAGS=${CFLAGS:--O2}
 CPPFLAGS=${CPPFLAGS:-}
 CXXFLAGS=${CXXFLAGS:-\$(CFLAGS)}
-- 
1.9.2

[PATCH v3] configure: use cc/c++ when GCC not installed

[Fraser Tweedale]

Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler
Collection.  Use generic cc/c++ as a fallback when gcc/g++ are not
available.
---
 configure | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 9bde2eb..59ab87b 100755
--- a/configure
+++ b/configure
@@ -43,8 +43,16 @@ fi
 
 # Set several defaults (optionally specified by the user in
 # environment variables)
-CC=${CC:-gcc}
-CXX=${CXX:-g++}
+if command -v gcc >/dev/null; then
+    CC=${CC:-gcc}
+else
+    CC=${CC:-cc}
+fi
+if command -v g++ >/dev/null; then
+    CXX=${CXX:-g++}
+else
+    CXX=${CXX:-c++}
+fi
 CFLAGS=${CFLAGS:--O2}
 CPPFLAGS=${CPPFLAGS:-}
 CXXFLAGS=${CXXFLAGS:-\$(CFLAGS)}
-- 
1.9.2

Re: [PATCH v2] configure: use cc/c++ instead of gcc/g++

[David Bremner]

Fraser Tweedale <frase@frase.id.au> writes:

> Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler
> Collection.  Use generic cc/c++ instead of gcc/g++ (unless the
> CC/CXX environment variables are used).

pushed to master.

d