* [PATCH] emacs: update alist for mail-archive.com API change
@ 2014-02-12 5:51 Jed Brown
2014-02-13 7:22 ` Austin Clements
2014-02-13 12:36 ` David Bremner
0 siblings, 2 replies; 5+ messages in thread
From: Jed Brown @ 2014-02-12 5:51 UTC (permalink / raw)
To: notmuch
Searching by Message-Id no longer works via the old mail-archive.com
API, though I have contacted them in hopes that they restore it to
prevent dead links. Anyway, the new API is cleaner.
---
emacs/notmuch-show.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 1ac80ca..88752f1 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -171,7 +171,7 @@ each attachment handler is logged in buffers with names beginning
(defcustom notmuch-show-stash-mlarchive-link-alist
'(("Gmane" . "http://mid.gmane.org/")
("MARC" . "http://marc.info/?i=")
- ("Mail Archive, The" . "http://mail-archive.com/search?l=mid&q=")
+ ("Mail Archive, The" . "http://mid.mail-archive.com/")
("LKML" . "http://lkml.kernel.org/r/")
;; FIXME: can these services be searched by `Message-Id' ?
;; ("MarkMail" . "http://markmail.org/")
--
1.8.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] emacs: update alist for mail-archive.com API change
2014-02-12 5:51 [PATCH] emacs: update alist for mail-archive.com API change Jed Brown
@ 2014-02-13 7:22 ` Austin Clements
2014-02-13 12:36 ` David Bremner
1 sibling, 0 replies; 5+ messages in thread
From: Austin Clements @ 2014-02-13 7:22 UTC (permalink / raw)
To: Jed Brown, notmuch
On Wed, 12 Feb 2014, Jed Brown <jed@jedbrown.org> wrote:
> Searching by Message-Id no longer works via the old mail-archive.com
> API, though I have contacted them in hopes that they restore it to
> prevent dead links. Anyway, the new API is cleaner.
> ---
> emacs/notmuch-show.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 1ac80ca..88752f1 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -171,7 +171,7 @@ each attachment handler is logged in buffers with names beginning
> (defcustom notmuch-show-stash-mlarchive-link-alist
> '(("Gmane" . "http://mid.gmane.org/")
> ("MARC" . "http://marc.info/?i=")
> - ("Mail Archive, The" . "http://mail-archive.com/search?l=mid&q=")
> + ("Mail Archive, The" . "http://mid.mail-archive.com/")
> ("LKML" . "http://lkml.kernel.org/r/")
> ;; FIXME: can these services be searched by `Message-Id' ?
> ;; ("MarkMail" . "http://markmail.org/")
> --
> 1.8.5.4
LGTM.
Curiously, if you go to just http://mid.mail-archive.com/, it redirects
to http://www.mail-archive.com/search?l=mid&q=message-id%3A%5C, which
suggests to me that they did not intend to break the old URLs. But I
agree that the new API is nicer (and produces shorter URLs).
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] emacs: update alist for mail-archive.com API change
2014-02-12 5:51 [PATCH] emacs: update alist for mail-archive.com API change Jed Brown
2014-02-13 7:22 ` Austin Clements
@ 2014-02-13 12:36 ` David Bremner
2014-02-13 15:04 ` Jed Brown
1 sibling, 1 reply; 5+ messages in thread
From: David Bremner @ 2014-02-13 12:36 UTC (permalink / raw)
To: Jed Brown, notmuch
Jed Brown <jed@jedbrown.org> writes:
> - ("Mail Archive, The" . "http://mail-archive.com/search?l=mid&q=")
> + ("Mail Archive, The" . "http://mid.mail-archive.com/")
the change looks reasonable, but it breaks one of the tests.
Please update the corresponding test at the same time.
d
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] emacs: update alist for mail-archive.com API change
2014-02-13 12:36 ` David Bremner
@ 2014-02-13 15:04 ` Jed Brown
2014-02-16 23:46 ` David Bremner
0 siblings, 1 reply; 5+ messages in thread
From: Jed Brown @ 2014-02-13 15:04 UTC (permalink / raw)
To: notmuch
Searching by Message-Id no longer works via the old mail-archive.com
API, though I have contacted them in hopes that they restore it to
prevent dead links. Anyway, the new API is cleaner.
Acked-by: Austin Clements <amdragon@MIT.EDU>
---
Fixed the test. Thanks, David.
emacs/notmuch-show.el | 2 +-
test/T310-emacs.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 1ac80ca..88752f1 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -171,7 +171,7 @@ each attachment handler is logged in buffers with names beginning
(defcustom notmuch-show-stash-mlarchive-link-alist
'(("Gmane" . "http://mid.gmane.org/")
("MARC" . "http://marc.info/?i=")
- ("Mail Archive, The" . "http://mail-archive.com/search?l=mid&q=")
+ ("Mail Archive, The" . "http://mid.mail-archive.com/")
("LKML" . "http://lkml.kernel.org/r/")
;; FIXME: can these services be searched by `Message-Id' ?
;; ("MarkMail" . "http://markmail.org/")
diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh
index 7dc9a8e..00ae96a 100755
--- a/test/T310-emacs.sh
+++ b/test/T310-emacs.sh
@@ -727,7 +727,7 @@ inbox,stashtest
${gen_msg_filename}
http://mid.gmane.org/bought
http://marc.info/?i=bought
-http://mail-archive.com/search?l=mid&q=bought
+http://mid.mail-archive.com/bought
EOF
test_expect_equal_file OUTPUT EXPECTED
--
1.8.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] emacs: update alist for mail-archive.com API change
2014-02-13 15:04 ` Jed Brown
@ 2014-02-16 23:46 ` David Bremner
0 siblings, 0 replies; 5+ messages in thread
From: David Bremner @ 2014-02-16 23:46 UTC (permalink / raw)
To: Jed Brown, notmuch
Jed Brown <jed@jedbrown.org> writes:
> Searching by Message-Id no longer works via the old mail-archive.com
> API, though I have contacted them in hopes that they restore it to
> prevent dead links. Anyway, the new API is cleaner.
>
> Acked-by: Austin Clements <amdragon@MIT.EDU>
> ---
> Fixed the test. Thanks, David.
pushed, thanks
d
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-16 23:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-12 5:51 [PATCH] emacs: update alist for mail-archive.com API change Jed Brown
2014-02-13 7:22 ` Austin Clements
2014-02-13 12:36 ` David Bremner
2014-02-13 15:04 ` Jed Brown
2014-02-16 23:46 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).