From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 1/4] contrib: pick: print () for a message with no tags
Date: Mon, 2 Sep 2013 04:28:05 +0100 [thread overview]
Message-ID: <1378092488-32050-2-git-send-email-markwalters1009@gmail.com> (raw)
In-Reply-To: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com>
Dating back to the earliest notmuch-pick we have not printed anything
for the tag field for a message with no tags. This is inconsistent
with search and show both of which print "()". Change pick to be
consistent.
---
contrib/notmuch-pick/notmuch-pick.el | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index 37dc161..063d660 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -652,10 +652,9 @@ unchanged ADDRESS if parsing fails."
(face (if match
'notmuch-pick-match-tag-face
'notmuch-pick-no-match-tag-face)))
- (when tags
- (insert (propertize (format format-string
- (mapconcat #'identity tags ", "))
- 'face face))))))))
+ (insert (propertize (format format-string
+ (mapconcat #'identity tags ", "))
+ 'face face)))))))
(defun notmuch-pick-insert-msg (msg)
"Insert the message MSG according to notmuch-pick-result-format"
--
1.7.9.1
next prev parent reply other threads:[~2013-09-02 3:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 3:28 [PATCH 0/4] contrib: pick: allow more general format lines Mark Walters
2013-09-02 3:28 ` Mark Walters [this message]
2013-09-02 3:28 ` [PATCH 2/4] contrib: pick: move the insertion of fields up a level Mark Walters
2013-09-02 3:28 ` [PATCH 3/4] contrib: pick: allow recursive message field formats Mark Walters
2013-09-02 3:28 ` [PATCH 4/4] contrib: pick: make the tree graphics a proper part of the format Mark Walters
2013-09-02 3:36 ` [PATCH 0/4] contrib: pick: allow more general format lines Mark Walters
2013-09-14 9:54 ` Tomi Ollila
2013-09-15 12:06 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378092488-32050-2-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).