From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 51AD8431FD6 for ; Sun, 1 Sep 2013 20:28:23 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.201 X-Spam-Level: X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qqCVZkYhSAIU for ; Sun, 1 Sep 2013 20:28:17 -0700 (PDT) Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 534EC431FC7 for ; Sun, 1 Sep 2013 20:28:17 -0700 (PDT) Received: by mail-we0-f176.google.com with SMTP id u56so592084wes.7 for ; Sun, 01 Sep 2013 20:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ySqqhHVxpqz0zMXb1B+D1my+dvD5e+W80OyfxEwG6BU=; b=RsySKvZ51ZKv9LcqgAV/txjLZAYRzp5wlE0Yp44GzJrb9+MC6US1X06DUjErubpnJ0 y6LCRGbBH5Z5uByZLRNSoYDbqeZrVsiTGiZXgSEuCRpZ5R2H9O5Wz5GuzvJ5S0E4WZab 38XTdrySxbRAG27Yhf6H8cPq/LoQqvrRaSwk+OkV0AXMQCYMqigvxF4SoBkVwpwZlSpu CCKDMv7mqJtFVVWpm9o28jzgX9WguyGTEV4oXiNE7UNdTiyzZsRXhYutsuJ1/QeJTi1t y/MB1rgbSCtrhlUbOiBgtE8kHw65iYmDj5ftmU4DLTnuzHWUdQy/Y5kY9c0KdZ2C05/T nP+w== X-Received: by 10.180.207.84 with SMTP id lu20mr11830739wic.50.1378092494964; Sun, 01 Sep 2013 20:28:14 -0700 (PDT) Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) by mx.google.com with ESMTPSA id fv10sm13582153wic.0.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 01 Sep 2013 20:28:14 -0700 (PDT) From: Mark Walters To: notmuch@notmuchmail.org Subject: [PATCH 1/4] contrib: pick: print () for a message with no tags Date: Mon, 2 Sep 2013 04:28:05 +0100 Message-Id: <1378092488-32050-2-git-send-email-markwalters1009@gmail.com> X-Mailer: git-send-email 1.7.9.1 In-Reply-To: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com> References: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Sep 2013 03:28:23 -0000 Dating back to the earliest notmuch-pick we have not printed anything for the tag field for a message with no tags. This is inconsistent with search and show both of which print "()". Change pick to be consistent. --- contrib/notmuch-pick/notmuch-pick.el | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el index 37dc161..063d660 100644 --- a/contrib/notmuch-pick/notmuch-pick.el +++ b/contrib/notmuch-pick/notmuch-pick.el @@ -652,10 +652,9 @@ unchanged ADDRESS if parsing fails." (face (if match 'notmuch-pick-match-tag-face 'notmuch-pick-no-match-tag-face))) - (when tags - (insert (propertize (format format-string - (mapconcat #'identity tags ", ")) - 'face face)))))))) + (insert (propertize (format format-string + (mapconcat #'identity tags ", ")) + 'face face))))))) (defun notmuch-pick-insert-msg (msg) "Insert the message MSG according to notmuch-pick-result-format" -- 1.7.9.1