[Patch (rebased) 0/2] contrib: pick: remove an unused variable

[Patch (rebased) 0/2] contrib: pick: remove an unused variable

[Mark Walters]

This is a rebased version of
id:1372712861-13515-1-git-send-email-markwalters1009@gmail.com.
 
When documenting notmuch-pick-worker I realised that
notmuch-pick-buffer-name was an essentially unused argument: it is
only used to reset itself on refresh.

(Possibly this was a mis-copy from notmuch-show or possibly a left
over from refesh used kill-buffer instead of erase-buffer.)

In any case we might as well remove it and then document the function.

Best wishes

Mark

Mark Walters (2):
  contrib: pick: remove unneeded variable notmuch-pick-buffer-name
  contrib: pick: add docstring for notmuch-pick-worker

 contrib/notmuch-pick/notmuch-pick.el |   19 ++++++++-----------
 1 files changed, 8 insertions(+), 11 deletions(-)

-- 
1.7.9.1

[Patch (rebased) 1/2] contrib: pick: remove unneeded variable notmuch-pick-buffer-name

[Mark Walters]

This variable is essentially unused: it was only used for making sure
it itself got reset after a refresh of the buffer.

It did this by passing an unnecessary argument to notmuch-pick-worker
so remove that too.
---
 contrib/notmuch-pick/notmuch-pick.el |   15 ++++-----------
 1 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index 37dc161..f6710e9 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -166,10 +166,6 @@
   "A buffer local copy of argument open-target to the function notmuch-pick")
 (make-variable-buffer-local 'notmuch-pick-open-target)
 
-(defvar notmuch-pick-buffer-name nil
-  "A buffer local copy of argument buffer-name to the function notmuch-pick")
-(make-variable-buffer-local 'notmuch-pick-buffer-name)
-
 (defvar notmuch-pick-message-window nil
   "The window of the message pane.
 
@@ -591,13 +587,11 @@ message will be \"unarchived\", i.e. the tag changes in
   (let ((inhibit-read-only t)
 	(basic-query notmuch-pick-basic-query)
 	(query-context notmuch-pick-query-context)
-	(target (notmuch-pick-get-message-id))
-	(buffer-name notmuch-pick-buffer-name))
+	(target (notmuch-pick-get-message-id)))
     (erase-buffer)
     (notmuch-pick-worker basic-query
 			 query-context
-			 target
-			 (get-buffer buffer-name))))
+			 target)))
 
 (defun notmuch-pick-clean-address (address)
   "Try to clean a single email ADDRESS for display. Return
@@ -800,12 +794,11 @@ Complete list of currently available key bindings:
 	(notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread
 					 results-buf)))))
 
-(defun notmuch-pick-worker (basic-query &optional query-context target buffer open-target)
+(defun notmuch-pick-worker (basic-query &optional query-context target open-target)
   (interactive)
   (notmuch-pick-mode)
   (setq notmuch-pick-basic-query basic-query)
   (setq notmuch-pick-query-context query-context)
-  (setq notmuch-pick-buffer-name (buffer-name buffer))
   (setq notmuch-pick-target-msg target)
   (setq notmuch-pick-open-target open-target)
 
@@ -864,7 +857,7 @@ The arguments are:
     ;; Don't track undo information for this buffer
     (set 'buffer-undo-list t)
 
-    (notmuch-pick-worker query query-context target buffer open-target)
+    (notmuch-pick-worker query query-context target open-target)
 
     (setq truncate-lines t)))
 
-- 
1.7.9.1

[Patch (rebased) 2/2] contrib: pick: add docstring for notmuch-pick-worker

[Mark Walters]

---
 contrib/notmuch-pick/notmuch-pick.el |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index f6710e9..30757c1 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -795,6 +795,10 @@ Complete list of currently available key bindings:
 					 results-buf)))))
 
 (defun notmuch-pick-worker (basic-query &optional query-context target open-target)
+  "Insert the actual pick search in the current buffer.
+
+This is is a helper function for notmuch-pick. The arguments are
+the same as for the function notmuch-pick."
   (interactive)
   (notmuch-pick-mode)
   (setq notmuch-pick-basic-query basic-query)
-- 
1.7.9.1

Re: [Patch (rebased) 0/2] contrib: pick: remove an unused variable

[Tomi Ollila]

On Sun, Aug 25 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> This is a rebased version of
> id:1372712861-13515-1-git-send-email-markwalters1009@gmail.com.
>  
> When documenting notmuch-pick-worker I realised that
> notmuch-pick-buffer-name was an essentially unused argument: it is
> only used to reset itself on refresh.
>
> (Possibly this was a mis-copy from notmuch-show or possibly a left
> over from refesh used kill-buffer instead of erase-buffer.)
>
> In any case we might as well remove it and then document the function.

LGTM.

Tomi

>
> Best wishes
>
> Mark
>
> Mark Walters (2):
>   contrib: pick: remove unneeded variable notmuch-pick-buffer-name
>   contrib: pick: add docstring for notmuch-pick-worker
>
>  contrib/notmuch-pick/notmuch-pick.el |   19 ++++++++-----------
>  1 files changed, 8 insertions(+), 11 deletions(-)
>
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch