[PATCH 0/8] packaging: fedora: general updates

[PATCH 0/8] packaging: fedora: general updates

[Felipe Contreras]

Hi,

It doesn't seem the spec file is properly maintained, it should be much better
now, closer to Fedora's one, and with support for Ruby bindings.

Felipe Contreras (8):
  packaging: fedora: update
  packaging: fedora: remove irrelevant stuff
  packaging: fedora: trivial cleanups
  packaging: fedora: reorganize files section
  packaging: fedora: separate package for emacs
  packaging: fedora: package python bindings
  packaging: fedora: package notmuch-mutt
  packaging: fedora: add ruby bindings

 packaging/fedora/notmuch.spec | 195 ++++++++++++++++++++++++------------------
 1 file changed, 111 insertions(+), 84 deletions(-)

-- 
1.8.2.1.1031.g2ee5873

[PATCH 1/8] packaging: fedora: update

[Felipe Contreras]

So at least it builds.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 packaging/fedora/notmuch.spec | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/packaging/fedora/notmuch.spec b/packaging/fedora/notmuch.spec
index ef1af2e..65c26db 100644
--- a/packaging/fedora/notmuch.spec
+++ b/packaging/fedora/notmuch.spec
@@ -25,7 +25,7 @@
 #
 
 Name:           notmuch
-Version:        0.4
+Version:        0.15.2
 Release:        1%{?dist}
 Summary:        Not much of an email program
 
@@ -99,14 +99,12 @@ developing applications that use %{name}.
 %setup -q
 
 %build
-./configure --prefix=/usr --libdir=%{_libdir} --sysconfdir=%{_sysconfdir}
+./configure --prefix=%{_prefix} --libdir=%{_libdir} --sysconfdir=%{_sysconfdir} \
+    --mandir=%{_mandir} --includedir=%{_includedir} --emacslispdir=%{_emacs_sitelispdir}
 make %{?_smp_mflags} CFLAGS="%{optflags}"
-emacs -batch -f batch-byte-compile emacs/*.el
 
 %install
-rm -rf %{buildroot}
-make install DESTDIR=%{buildroot} prefix=%{_prefix}
-mv %{buildroot}%{_sysconfdir}/bash_completion.d %{buildroot}%{_datarootdir}/bash_completion
+make install DESTDIR=%{buildroot}
 
 %clean
 rm -rf %{buildroot}
@@ -117,25 +115,28 @@ rm -rf %{buildroot}
 
 %files
 %defattr(-,root,root,-)
-%doc AUTHORS COPYING COPYING-GPL-3 INSTALL README TODO
+%doc AUTHORS COPYING COPYING-GPL-3 INSTALL README
 
 %{_bindir}/notmuch
-%{_libdir}/libnotmuch.so.*
-%{_mandir}/man1/notmuch.1*
+%{_libdir}/libnotmuch.so.3*
+%{_mandir}/man?/*
 
 %{_emacs_sitelispdir}/*
 
-%{_datarootdir}/zsh/functions/Completion/Unix/notmuch
-%{_datarootdir}/bash_completion/notmuch
+%{_datarootdir}/zsh/functions/Completion/Unix/_notmuch
+%{_sysconfdir}/bash_completion.d/notmuch
 
 %files devel
 %defattr(-,root,root,-)
-%doc AUTHORS COPYING COPYING-GPL-3 INSTALL README TODO
+%doc AUTHORS COPYING COPYING-GPL-3 INSTALL README
 %{_includedir}/*
 %{_libdir}/*.so
 
 
 %changelog
+* Sun Apr 28 2013 Felipe Contreras <felipe.contreras@gmail.com> - 0.15.2-1
+- Update to latest upstream
+
 * Tue Nov  2 2010 Scott Henson <shenson@redhat.com> - 0.4-1
 - New upstream release
 
-- 
1.8.2.1.1031.g2ee5873

[PATCH 2/8] packaging: fedora: remove irrelevant stuff

[Felipe Contreras]

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 packaging/fedora/notmuch.spec | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/packaging/fedora/notmuch.spec b/packaging/fedora/notmuch.spec
index 65c26db..a5191fc 100644
--- a/packaging/fedora/notmuch.spec
+++ b/packaging/fedora/notmuch.spec
@@ -1,16 +1,6 @@
 %global git 6b9a717c
 %global date %(date +%Y%m%d)
 
-%if %($(pkg-config emacs) ; echo $?)
-%global emacs_version 23.1
-%global emacs_lispdir %{_datadir}/emacs/site-lisp
-%global emacs_startdir %{_datadir}/emacs/site-lisp/site-start.d
-%else
-%global emacs_version %(pkg-config emacs --modversion)
-%global emacs_lispdir %(pkg-config emacs --variable sitepkglispdir)
-%global emacs_startdir %(pkg-config emacs --variable sitestartdir)
-%endif
-
 # If you are doing a git snapshot:
 #
 # Release should be 1%{git}%{?dist}
@@ -43,7 +33,7 @@ BuildRequires:  zlib-devel
 BuildRequires:  emacs-el
 BuildRequires:  emacs-nox
 
-Requires:       emacs(bin) >= %{emacs_version}
+Requires:       emacs(bin) >= %{_emacs_version}
 
 %description
 * "Not much mail" is what Notmuch thinks about your email
-- 
1.8.2.1.1031.g2ee5873

[PATCH 3/8] packaging: fedora: trivial cleanups

[Felipe Contreras]

Mostly to sync with Fedora's spec.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 packaging/fedora/notmuch.spec | 72 +++++++++++--------------------------------
 1 file changed, 18 insertions(+), 54 deletions(-)

diff --git a/packaging/fedora/notmuch.spec b/packaging/fedora/notmuch.spec
index a5191fc..6d32bdd 100644
--- a/packaging/fedora/notmuch.spec
+++ b/packaging/fedora/notmuch.spec
@@ -17,71 +17,38 @@
 Name:           notmuch
 Version:        0.15.2
 Release:        1%{?dist}
-Summary:        Not much of an email program
+Summary:        Thread-based email index, search and tagging
 
 Group:          Applications/Internet
 License:        GPLv3+
 URL:            http://notmuchmail.org/
 
 Source0:        http://notmuchmail.org/releases/notmuch-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
-BuildRequires:  xapian-core-devel
-BuildRequires:  gmime-devel
-BuildRequires:  libtalloc-devel
-BuildRequires:  zlib-devel
-BuildRequires:  emacs-el
-BuildRequires:  emacs-nox
+BuildRequires:  xapian-core-devel gmime-devel libtalloc-devel
+BuildRequires:  zlib-devel emacs-el emacs-nox
 
 Requires:       emacs(bin) >= %{_emacs_version}
 
 %description
-* "Not much mail" is what Notmuch thinks about your email
-  collection. Even if you receive 12000 messages per month or have on
-  the order of millions of messages that you've been saving for
-  decades. Regardless, Notmuch will be able to quickly search all of
-  it. It's just plain not much mail.
-
-* "Not much mail" is also what you should have in your inbox at any
-  time. Notmuch gives you what you need, (tags and fast search), so
-  that you can keep your inbox tamed and focus on what really matters
-  in your life, (which is surely not email).
-
-* Notmuch is an answer to Sup. Sup is a very good email program
-  written by William Morgan (and others) and is the direct inspiration
-  for Notmuch. Notmuch began as an effort to rewrite
-  performance-critical pieces of Sup in C rather than ruby. From
-  there, it grew into a separate project. One significant contribution
-  Notmuch makes compared to Sup is the separation of the
-  indexer/searcher from the user interface. (Notmuch provides a
-  library interface so that its indexing/searching/tagging features
-  can be integrated into any email program.)
-
-* Notmuch is not much of an email program. It doesn't receive messages
-  (no POP or IMAP support). It doesn't send messages (no mail composer,
-  no network code at all). And for what it does do (email search) that
-  work is provided by an external library, Xapian. So if Notmuch
-  provides no user interface and Xapian does all the heavy lifting,
-  then what's left here? Not much.
-
-Notmuch is still in the early stages of development, but it does
-include one user interface, (implemented within Emacs), which has at
-least two users using it for reading all of their incoming mail. If
-you've been looking for a fast, global-search and tag-based email
-reader to use within Emacs, then Notmuch may be exactly what you've
-been looking for.
-
-Otherwise, if you're a developer of an existing email program and
-would love a good library interface for fast, global search with
-support for arbitrary tags, then Notmuch also may be exactly what
-you've been looking for.
-
-%package        devel
-Summary:        Development files for %{name}
+Fast system for indexing, searching, and tagging email.  Even if you
+receive 12000 messages per month or have on the order of millions of
+messages that you've been saving for decades, Notmuch will be able to
+quickly search all of it.
+
+Notmuch is not much of an email program. It doesn't receive messages
+(no POP or IMAP support). It doesn't send messages (no mail composer,
+no network code at all). And for what it does do (email search) that
+work is provided by an external library, Xapian. So if Notmuch
+provides no user interface and Xapian does all the heavy lifting, then
+what's left here? Not much.
+
+%package devel
+Summary:        Development libraries and header files for %{name}
 Group:          Development/Libraries
 Requires:       %{name} = %{version}-%{release}
 
-%description    devel
+%description devel
 The %{name}-devel package contains libraries and header files for
 developing applications that use %{name}.
 
@@ -96,9 +63,6 @@ make %{?_smp_mflags} CFLAGS="%{optflags}"
 %install
 make install DESTDIR=%{buildroot}
 
-%clean
-rm -rf %{buildroot}
-
 %post -p /sbin/ldconfig
 
 %postun -p /sbin/ldconfig
-- 
1.8.2.1.1031.g2ee5873

[PATCH 4/8] packaging: fedora: reorganize files section

[Felipe Contreras]

Also to sync with Fedora.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 packaging/fedora/notmuch.spec | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/packaging/fedora/notmuch.spec b/packaging/fedora/notmuch.spec
index 6d32bdd..f5272db 100644
--- a/packaging/fedora/notmuch.spec
+++ b/packaging/fedora/notmuch.spec
@@ -68,24 +68,18 @@ make install DESTDIR=%{buildroot}
 %postun -p /sbin/ldconfig
 
 %files
-%defattr(-,root,root,-)
 %doc AUTHORS COPYING COPYING-GPL-3 INSTALL README
-
+%{_sysconfdir}/bash_completion.d/notmuch
+%{_datadir}/zsh/functions/Completion/Unix/_notmuch
 %{_bindir}/notmuch
-%{_libdir}/libnotmuch.so.3*
 %{_mandir}/man?/*
+%{_libdir}/libnotmuch.so.3*
 
 %{_emacs_sitelispdir}/*
 
-%{_datarootdir}/zsh/functions/Completion/Unix/_notmuch
-%{_sysconfdir}/bash_completion.d/notmuch
-
 %files devel
-%defattr(-,root,root,-)
-%doc AUTHORS COPYING COPYING-GPL-3 INSTALL README
+%{_libdir}/libnotmuch.so
 %{_includedir}/*
-%{_libdir}/*.so
-
 
 %changelog
 * Sun Apr 28 2013 Felipe Contreras <felipe.contreras@gmail.com> - 0.15.2-1
-- 
1.8.2.1.1031.g2ee5873

[PATCH 5/8] packaging: fedora: separate package for emacs

[Felipe Contreras]

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 packaging/fedora/notmuch.spec | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/packaging/fedora/notmuch.spec b/packaging/fedora/notmuch.spec
index f5272db..1e6ec3b 100644
--- a/packaging/fedora/notmuch.spec
+++ b/packaging/fedora/notmuch.spec
@@ -28,8 +28,6 @@ Source0:        http://notmuchmail.org/releases/notmuch-%{version}.tar.gz
 BuildRequires:  xapian-core-devel gmime-devel libtalloc-devel
 BuildRequires:  zlib-devel emacs-el emacs-nox
 
-Requires:       emacs(bin) >= %{_emacs_version}
-
 %description
 Fast system for indexing, searching, and tagging email.  Even if you
 receive 12000 messages per month or have on the order of millions of
@@ -52,6 +50,15 @@ Requires:       %{name} = %{version}-%{release}
 The %{name}-devel package contains libraries and header files for
 developing applications that use %{name}.
 
+%package -n emacs-notmuch
+Summary:        Not much support for Emacs
+Group:          Applications/Editors
+BuildArch:      noarch
+Requires:       %{name} = %{version}-%{release}, emacs(bin) >= %{_emacs_version}
+
+%description -n emacs-notmuch
+%{summary}.
+
 %prep
 %setup -q
 
@@ -75,12 +82,13 @@ make install DESTDIR=%{buildroot}
 %{_mandir}/man?/*
 %{_libdir}/libnotmuch.so.3*
 
-%{_emacs_sitelispdir}/*
-
 %files devel
 %{_libdir}/libnotmuch.so
 %{_includedir}/*
 
+%files -n emacs-notmuch
+%{_emacs_sitelispdir}/*
+
 %changelog
 * Sun Apr 28 2013 Felipe Contreras <felipe.contreras@gmail.com> - 0.15.2-1
 - Update to latest upstream
-- 
1.8.2.1.1031.g2ee5873

[PATCH 6/8] packaging: fedora: package python bindings

[Felipe Contreras]

Like in Fedora.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 packaging/fedora/notmuch.spec | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/packaging/fedora/notmuch.spec b/packaging/fedora/notmuch.spec
index 1e6ec3b..bc0a58c 100644
--- a/packaging/fedora/notmuch.spec
+++ b/packaging/fedora/notmuch.spec
@@ -26,7 +26,7 @@ URL:            http://notmuchmail.org/
 Source0:        http://notmuchmail.org/releases/notmuch-%{version}.tar.gz
 
 BuildRequires:  xapian-core-devel gmime-devel libtalloc-devel
-BuildRequires:  zlib-devel emacs-el emacs-nox
+BuildRequires:  zlib-devel emacs-el emacs-nox python
 
 %description
 Fast system for indexing, searching, and tagging email.  Even if you
@@ -59,6 +59,15 @@ Requires:       %{name} = %{version}-%{release}, emacs(bin) >= %{_emacs_version}
 %description -n emacs-notmuch
 %{summary}.
 
+%package -n python-notmuch
+Summary:        Python bindings for notmuch
+Group:          Development/Libraries
+BuildArch:      noarch
+Requires:       %{name} = %{version}-%{release}
+
+%description -n python-notmuch
+%{summary}.
+
 %prep
 %setup -q
 
@@ -67,9 +76,17 @@ Requires:       %{name} = %{version}-%{release}, emacs(bin) >= %{_emacs_version}
     --mandir=%{_mandir} --includedir=%{_includedir} --emacslispdir=%{_emacs_sitelispdir}
 make %{?_smp_mflags} CFLAGS="%{optflags}"
 
+pushd bindings/python
+    python setup.py build
+popd
+
 %install
 make install DESTDIR=%{buildroot}
 
+pushd bindings/python
+    python setup.py install -O1 --skip-build --root %{buildroot}
+popd
+
 %post -p /sbin/ldconfig
 
 %postun -p /sbin/ldconfig
@@ -89,6 +106,11 @@ make install DESTDIR=%{buildroot}
 %files -n emacs-notmuch
 %{_emacs_sitelispdir}/*
 
+%files -n python-notmuch
+%doc bindings/python/README
+%{python_sitelib}/*
+
+
 %changelog
 * Sun Apr 28 2013 Felipe Contreras <felipe.contreras@gmail.com> - 0.15.2-1
 - Update to latest upstream
-- 
1.8.2.1.1031.g2ee5873

[PATCH 7/8] packaging: fedora: package notmuch-mutt

[Felipe Contreras]

From Fedora.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 packaging/fedora/notmuch.spec | 28 ++++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/packaging/fedora/notmuch.spec b/packaging/fedora/notmuch.spec
index bc0a58c..11a1ec9 100644
--- a/packaging/fedora/notmuch.spec
+++ b/packaging/fedora/notmuch.spec
@@ -16,7 +16,7 @@
 
 Name:           notmuch
 Version:        0.15.2
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Thread-based email index, search and tagging
 
 Group:          Applications/Internet
@@ -26,7 +26,7 @@ URL:            http://notmuchmail.org/
 Source0:        http://notmuchmail.org/releases/notmuch-%{version}.tar.gz
 
 BuildRequires:  xapian-core-devel gmime-devel libtalloc-devel
-BuildRequires:  zlib-devel emacs-el emacs-nox python
+BuildRequires:  zlib-devel emacs-el emacs-nox python perl
 
 %description
 Fast system for indexing, searching, and tagging email.  Even if you
@@ -68,6 +68,17 @@ Requires:       %{name} = %{version}-%{release}
 %description -n python-notmuch
 %{summary}.
 
+%package mutt
+Summary:        Notmuch (of a) helper for Mutt
+Group:          Development/Libraries
+BuildArch:      noarch
+Requires:       %{name} = %{version}-%{release}
+Requires:       perl(Term::ReadLine::Gnu)
+
+%description mutt
+notmuch-mutt provide integration among the Mutt mail user agent and
+the Notmuch mail indexer.
+
 %prep
 %setup -q
 
@@ -80,6 +91,10 @@ pushd bindings/python
     python setup.py build
 popd
 
+pushd contrib/notmuch-mutt
+    make
+popd
+
 %install
 make install DESTDIR=%{buildroot}
 
@@ -87,6 +102,9 @@ pushd bindings/python
     python setup.py install -O1 --skip-build --root %{buildroot}
 popd
 
+install contrib/notmuch-mutt/notmuch-mutt %{buildroot}%{_bindir}/notmuch-mutt
+install contrib/notmuch-mutt/notmuch-mutt.1 %{buildroot}%{_mandir}/man1/notmuch-mutt.1
+
 %post -p /sbin/ldconfig
 
 %postun -p /sbin/ldconfig
@@ -110,8 +128,14 @@ popd
 %doc bindings/python/README
 %{python_sitelib}/*
 
+%files mutt
+%{_bindir}/notmuch-mutt
+%{_mandir}/man1/notmuch-mutt.1*
 
 %changelog
+* Sun Apr 28 2013 Felipe Contreras <felipe.contreras@gmail.com> - 0.15.2-2
+- Sync with Fedora
+
 * Sun Apr 28 2013 Felipe Contreras <felipe.contreras@gmail.com> - 0.15.2-1
 - Update to latest upstream
 
-- 
1.8.2.1.1031.g2ee5873

[PATCH 8/8] packaging: fedora: add ruby bindings

[Felipe Contreras]

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 packaging/fedora/notmuch.spec | 28 ++++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/packaging/fedora/notmuch.spec b/packaging/fedora/notmuch.spec
index 11a1ec9..79994c9 100644
--- a/packaging/fedora/notmuch.spec
+++ b/packaging/fedora/notmuch.spec
@@ -16,7 +16,7 @@
 
 Name:           notmuch
 Version:        0.15.2
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        Thread-based email index, search and tagging
 
 Group:          Applications/Internet
@@ -26,7 +26,7 @@ URL:            http://notmuchmail.org/
 Source0:        http://notmuchmail.org/releases/notmuch-%{version}.tar.gz
 
 BuildRequires:  xapian-core-devel gmime-devel libtalloc-devel
-BuildRequires:  zlib-devel emacs-el emacs-nox python perl
+BuildRequires:  zlib-devel emacs-el emacs-nox python ruby ruby-devel perl
 
 %description
 Fast system for indexing, searching, and tagging email.  Even if you
@@ -68,6 +68,14 @@ Requires:       %{name} = %{version}-%{release}
 %description -n python-notmuch
 %{summary}.
 
+%package -n notmuch-ruby
+Summary:        Ruby bindings for notmuch
+Group:          Development/Libraries
+Requires:       %{name} = %{version}-%{release}
+
+%description -n notmuch-ruby
+%{summary}.
+
 %package mutt
 Summary:        Notmuch (of a) helper for Mutt
 Group:          Development/Libraries
@@ -91,6 +99,12 @@ pushd bindings/python
     python setup.py build
 popd
 
+pushd bindings/ruby
+    export CONFIGURE_ARGS="--with-cflags='%{optflags}'"
+    ruby extconf.rb --vendor
+    make
+popd
+
 pushd contrib/notmuch-mutt
     make
 popd
@@ -102,6 +116,10 @@ pushd bindings/python
     python setup.py install -O1 --skip-build --root %{buildroot}
 popd
 
+pushd bindings/ruby
+    make install DESTDIR=%{buildroot}
+popd
+
 install contrib/notmuch-mutt/notmuch-mutt %{buildroot}%{_bindir}/notmuch-mutt
 install contrib/notmuch-mutt/notmuch-mutt.1 %{buildroot}%{_mandir}/man1/notmuch-mutt.1
 
@@ -128,11 +146,17 @@ install contrib/notmuch-mutt/notmuch-mutt.1 %{buildroot}%{_mandir}/man1/notmuch-
 %doc bindings/python/README
 %{python_sitelib}/*
 
+%files -n notmuch-ruby
+%{ruby_vendorarchdir}/*
+
 %files mutt
 %{_bindir}/notmuch-mutt
 %{_mandir}/man1/notmuch-mutt.1*
 
 %changelog
+* Sun Apr 28 2013 Felipe Contreras <felipe.contreras@gmail.com> - 0.15.2-3
+- Add ruby bingings
+
 * Sun Apr 28 2013 Felipe Contreras <felipe.contreras@gmail.com> - 0.15.2-2
 - Sync with Fedora
 
-- 
1.8.2.1.1031.g2ee5873

Re: [PATCH 0/8] packaging: fedora: general updates

[Felipe Contreras]

On Sun, Apr 28, 2013 at 4:52 AM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:

> It doesn't seem the spec file is properly maintained, it should be much better
> now, closer to Fedora's one, and with support for Ruby bindings.

What about these?

-- 
Felipe Contreras

Re: [PATCH 0/8] packaging: fedora: general updates

[Tomi Ollila]

On Sun, Apr 28 2013, Felipe Contreras <felipe.contreras@gmail.com> wrote:

> Hi,
>
> It doesn't seem the spec file is properly maintained, it should be much better
> now, closer to Fedora's one, and with support for Ruby bindings.
>
> Felipe Contreras (8):
>   packaging: fedora: update
>   packaging: fedora: remove irrelevant stuff
>   packaging: fedora: trivial cleanups
>   packaging: fedora: reorganize files section
>   packaging: fedora: separate package for emacs
>   packaging: fedora: package python bindings
>   packaging: fedora: package notmuch-mutt
>   packaging: fedora: add ruby bindings
>
>  packaging/fedora/notmuch.spec | 195 ++++++++++++++++++++++++------------------
>  1 file changed, 111 insertions(+), 84 deletions(-)

This series looks ok to me -- in full, w/o last 1-2 patches or last 1-2
patches in outcommented format (depending on the consistency "policy").  


> 1.8.2.1.1031.g2ee5873

Tomi

Re: [PATCH 0/8] packaging: fedora: general updates

[David Bremner]

Felipe Contreras <felipe.contreras@gmail.com> writes:

> On Sun, Apr 28, 2013 at 4:52 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>
>> It doesn't seem the spec file is properly maintained, it should be much better
>> now, closer to Fedora's one, and with support for Ruby bindings.
>
> What about these?
>

Hi Felipe

At this point we wait for somebody (else) with Fedora expertise to
review the patches.

Maybe your ping will inspire someone. Or, at the risk of telling you
things you already know, maybe reviewing other people's patches will
make them keaner enough to review yours [1].

d

[1]: http://notmuchmail.org/contributing/

Re: [PATCH 0/8] packaging: fedora: general updates

[Felipe Contreras]

On Sat, May 25, 2013 at 7:41 AM, David Bremner <david@tethera.net> wrote:

> At this point we wait for somebody (else) with Fedora expertise to
> review the patches.

Like who? I though the reason these were never updated is that there
wasn't anybody else.

-- 
Felipe Contreras

Re: [PATCH 1/8] packaging: fedora: update

[David Bremner]

Felipe Contreras <felipe.contreras@gmail.com> writes:
>  Name:           notmuch
> -Version:        0.4
> +Version:        0.15.2
>  Release:        1%{?dist}
>  Summary:        Not much of an email program

It might be good in the future do some kind of automated update of the
version. The python bindings version is currently updaded by a sed hack
in the target update-versions.

d

Re: [PATCH 0/8] packaging: fedora: general updates

[David Bremner]

Felipe Contreras <felipe.contreras@gmail.com> writes:

> On Sat, May 25, 2013 at 7:41 AM, David Bremner <david@tethera.net> wrote:
>
>> At this point we wait for somebody (else) with Fedora expertise to
>> review the patches.
>
> Like who? I though the reason these were never updated is that there
> wasn't anybody else.

Hmm. Somehow I missed Tomi's review. Anyway, pushed now.

d