unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] contrib: pick: Do not indent messages in the message pane
@ 2012-12-09 20:30 Mark Walters
  2012-12-17 16:26 ` Tomi Ollila
  2012-12-17 17:51 ` Jameson Graef Rollins
  0 siblings, 2 replies; 3+ messages in thread
From: Mark Walters @ 2012-12-09 20:30 UTC (permalink / raw)
  To: notmuch

Currently pick just uses notmuch-show to display messages in the
message pane: this means that they get indented just as show
would. However, since pick is only displaying one message at a time
there is no need to indent so override the indentation.
---

Thanks to jrollins for the suggestion. It would also be possible to
indent the headers (as a visual clue to how deep we are in the thread)
or to make this customisable. However there is no point in doing that
unless someone says they would prefer something else.

Best wishes

Mark



 contrib/notmuch-pick/notmuch-pick.el |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index cf026af..ce5d0d4 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -337,8 +337,10 @@ Does NOT change the database."
       (setq notmuch-pick-message-window
 	    (split-window-vertically (/ (window-height) 4)))
       (with-selected-window notmuch-pick-message-window
-	(setq current-prefix-arg '(4))
-	(setq buffer (notmuch-show id nil nil nil)))
+	;; Since we are only displaying one message do not indent.
+	(let ((notmuch-show-indent-messages-width 0))
+	  (setq current-prefix-arg '(4))
+	  (setq buffer (notmuch-show id nil nil nil))))
       (notmuch-pick-tag-update-display (list "-unread"))
       (setq notmuch-pick-message-buffer buffer))))
 
-- 
1.7.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] contrib: pick: Do not indent messages in the message pane
  2012-12-09 20:30 [PATCH] contrib: pick: Do not indent messages in the message pane Mark Walters
@ 2012-12-17 16:26 ` Tomi Ollila
  2012-12-17 17:51 ` Jameson Graef Rollins
  1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2012-12-17 16:26 UTC (permalink / raw)
  To: Mark Walters, notmuch

On Sun, Dec 09 2012, Mark Walters wrote:

> Currently pick just uses notmuch-show to display messages in the
> message pane: this means that they get indented just as show
> would. However, since pick is only displaying one message at a time
> there is no need to indent so override the indentation.
> ---

LGTM.

Tomi

>
> Thanks to jrollins for the suggestion. It would also be possible to
> indent the headers (as a visual clue to how deep we are in the thread)
> or to make this customisable. However there is no point in doing that
> unless someone says they would prefer something else.
>
> Best wishes
>
> Mark
>
>
>
>  contrib/notmuch-pick/notmuch-pick.el |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index cf026af..ce5d0d4 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -337,8 +337,10 @@ Does NOT change the database."
>        (setq notmuch-pick-message-window
>  	    (split-window-vertically (/ (window-height) 4)))
>        (with-selected-window notmuch-pick-message-window
> -	(setq current-prefix-arg '(4))
> -	(setq buffer (notmuch-show id nil nil nil)))
> +	;; Since we are only displaying one message do not indent.
> +	(let ((notmuch-show-indent-messages-width 0))
> +	  (setq current-prefix-arg '(4))
> +	  (setq buffer (notmuch-show id nil nil nil))))
>        (notmuch-pick-tag-update-display (list "-unread"))
>        (setq notmuch-pick-message-buffer buffer))))
>  
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] contrib: pick: Do not indent messages in the message pane
  2012-12-09 20:30 [PATCH] contrib: pick: Do not indent messages in the message pane Mark Walters
  2012-12-17 16:26 ` Tomi Ollila
@ 2012-12-17 17:51 ` Jameson Graef Rollins
  1 sibling, 0 replies; 3+ messages in thread
From: Jameson Graef Rollins @ 2012-12-17 17:51 UTC (permalink / raw)
  To: Mark Walters, notmuch

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

On Sun, Dec 09 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> Currently pick just uses notmuch-show to display messages in the
> message pane: this means that they get indented just as show
> would. However, since pick is only displaying one message at a time
> there is no need to indent so override the indentation.

Tested and LGTM.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-12-17 17:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-09 20:30 [PATCH] contrib: pick: Do not indent messages in the message pane Mark Walters
2012-12-17 16:26 ` Tomi Ollila
2012-12-17 17:51 ` Jameson Graef Rollins

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).