[PATCH v3] contrib: pick: bugfix when trying to show a non-message

[PATCH v3] contrib: pick: bugfix when trying to show a non-message

[Mark Walters]

If the user pressed return on the end result status line it gave a
blank message. Modify the function notmuch-pick-get-message-id to
return nil rather than an empty message-id in this case to fix this.

This also fixes a bug in the (lack of) quoting of the id string.
---

v2 is at id:1352562350-8219-1-git-send-email-markwalters1009@gmail.com

As suggested by bremner make the nil return from the if clause
explicit (as that is the point of the change).


 contrib/notmuch-pick/notmuch-pick.el |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index 15ac5e8..4db9632 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -241,7 +241,10 @@ Some useful entries are:
 
 (defun notmuch-pick-get-message-id ()
   "Return the message id of the current message."
-  (concat "id:\"" (notmuch-pick-get-prop :id) "\""))
+  (let ((id (notmuch-pick-get-prop :id)))
+    (if id
+	(notmuch-id-to-query id)
+      nil)))
 
 (defun notmuch-pick-get-match ()
   "Return whether the current message is a match."
-- 
1.7.9.1

Re: [PATCH v3] contrib: pick: bugfix when trying to show a non-message

[David Bremner]

Mark Walters <markwalters1009@gmail.com> writes:

> If the user pressed return on the end result status line it gave a
> blank message. Modify the function notmuch-pick-get-message-id to
> return nil rather than an empty message-id in this case to fix this.

pushed, 

d