From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 1/5] config: disable addition of exclude tags for 0.12
Date: Wed, 29 Feb 2012 18:13:05 +0000 [thread overview]
Message-ID: <1330539189-16593-2-git-send-email-markwalters1009@gmail.com> (raw)
In-Reply-To: <1330539189-16593-1-git-send-email-markwalters1009@gmail.com>
This disables the addition of search_exclude_tags in notmuch-setup and
notmuch-config.
---
notmuch-config.c | 3 +--
notmuch-setup.c | 19 +------------------
2 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/notmuch-config.c b/notmuch-config.c
index e9b2750..61fda3e 100644
--- a/notmuch-config.c
+++ b/notmuch-config.c
@@ -377,8 +377,7 @@ notmuch_config_open (void *ctx,
if (notmuch_config_get_search_exclude_tags (config, &tmp) == NULL) {
if (is_new) {
- const char *tags[] = { "deleted", "spam" };
- notmuch_config_set_search_exclude_tags (config, tags, 2);
+ /* We do not set default search_exclude_tags for 0.12 */
} else {
notmuch_config_set_search_exclude_tags (config, NULL, 0);
}
diff --git a/notmuch-setup.c b/notmuch-setup.c
index 94d0aa7..307231d 100644
--- a/notmuch-setup.c
+++ b/notmuch-setup.c
@@ -133,8 +133,6 @@ notmuch_setup_command (unused (void *ctx),
int is_new;
const char **new_tags;
size_t new_tags_len;
- const char **search_exclude_tags;
- size_t search_exclude_tags_len;
#define prompt(format, ...) \
do { \
@@ -211,22 +209,7 @@ notmuch_setup_command (unused (void *ctx),
}
- search_exclude_tags = notmuch_config_get_search_exclude_tags (config, &search_exclude_tags_len);
-
- printf ("Tags to exclude when searching messages (separated by spaces) [");
- print_tag_list (search_exclude_tags, search_exclude_tags_len);
- prompt ("]: ");
-
- if (strlen (response)) {
- GPtrArray *tags = parse_tag_list (ctx, response);
-
- notmuch_config_set_search_exclude_tags (config,
- (const char **) tags->pdata,
- tags->len);
-
- g_ptr_array_free (tags, TRUE);
- }
-
+ /* Temporarily remove exclude tag support for 0.12 */
if (! notmuch_config_save (config)) {
if (is_new)
--
1.7.2.3
next prev parent reply other threads:[~2012-02-29 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 18:13 [PATCH 0/5] Disable search.exclude_tags for 0.12 Mark Walters
2012-02-29 18:13 ` Mark Walters [this message]
2012-02-29 18:13 ` [PATCH 2/5] NEWS: revert NEWS item for exclude tags " Mark Walters
2012-02-29 18:13 ` [PATCH 3/5] man: remove search.exclude_tags from notmuch-config.1 " Mark Walters
2012-02-29 18:13 ` [PATCH 4/5] cli: temporarily remove exclude tag support " Mark Walters
2012-02-29 18:13 ` [PATCH 5/5] test: mark exclude tests broken " Mark Walters
2012-03-01 8:48 ` [PATCH 0/5] Disable search.exclude_tags " Tomi Ollila
2012-03-03 16:25 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330539189-16593-2-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).