unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 0/5] Disable search.exclude_tags for 0.12 
Date: Wed, 29 Feb 2012 18:13:04 +0000	[thread overview]
Message-ID: <1330539189-16593-1-git-send-email-markwalters1009@gmail.com> (raw)

As requested by David (Bremner) on irc here is a patch series
disabling the search.exclude_tags feature as a temporary measure for
the 0.12 release.

There are two options:

The first is to disable the addition of the new search.exclude_tags
item to the config file and stop setup from asking for it.

The second is to do the above and also disable the functionality in
notmuch-search.c and notmuch-count.c.

The idea is that this these are minimal (and thus relatively safe)
changes to make.  With the first option users who have configured the
functionality for themselves (while using git) will still get the
feature: it just won't be pushed on users. With the second option the
festure will be completely disabled.

Essentially patch 1 implements the first option and patch 4 the second
option.  The other patches in the series update the NEWS file, the man
page and the tests. If going for the first option then I would suggest
applying (in addition to patch 1) patch 2 (NEWS) and probably patch 3
(man) although as the functionality remains the latter is not strictly
necessary. The test patch (patch 5) is not necessary as the tests set
search.exclude_tags directly.

If going for the second option then all the patches are needed.

Finally, please could someone familiar with the config/setup code
check patch 1 carefully. I have never looked at that code before and
could easily have done something stupid.

Best wishes

Mark

Mark Walters (5):
  config: disable addition of exclude tags for 0.12
  NEWS: revert NEWS item for exclude tags for 0.12
  man: remove search.exclude_tags from notmuch-config.1 for 0.12
  cli: temporarily remove exclude tag support for 0.12
  test: mark exclude tests broken for 0.12

 NEWS                      |   18 ------------------
 man/man1/notmuch-config.1 |    8 --------
 notmuch-config.c          |    3 +--
 notmuch-count.c           |    8 +-------
 notmuch-search.c          |    8 +-------
 notmuch-setup.c           |   19 +------------------
 test/search               |    2 ++
 7 files changed, 6 insertions(+), 60 deletions(-)

-- 
1.7.2.3

             reply	other threads:[~2012-02-29 18:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 18:13 Mark Walters [this message]
2012-02-29 18:13 ` [PATCH 1/5] config: disable addition of exclude tags for 0.12 Mark Walters
2012-02-29 18:13 ` [PATCH 2/5] NEWS: revert NEWS item for " Mark Walters
2012-02-29 18:13 ` [PATCH 3/5] man: remove search.exclude_tags from notmuch-config.1 " Mark Walters
2012-02-29 18:13 ` [PATCH 4/5] cli: temporarily remove exclude tag support " Mark Walters
2012-02-29 18:13 ` [PATCH 5/5] test: mark exclude tests broken " Mark Walters
2012-03-01  8:48 ` [PATCH 0/5] Disable search.exclude_tags " Tomi Ollila
2012-03-03 16:25 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330539189-16593-1-git-send-email-markwalters1009@gmail.com \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).