* [PATCH 0/2] adjust the new movement commands
@ 2012-01-31 8:01 David Edmondson
2012-01-31 8:01 ` [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread David Edmondson
2012-01-31 8:01 ` [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer David Edmondson
0 siblings, 2 replies; 17+ messages in thread
From: David Edmondson @ 2012-01-31 8:01 UTC (permalink / raw)
To: notmuch
After Jameson's recent work the precise behaviour of 'a' and ' ' in
`notmuch-show-mode' changed slightly. Revert to something nearer the
previous behaviour.
David Edmondson (2):
emacs: If archiving the last message in a thread, show the next
thread.
emacs: Don't move to the next thread unless the cursor is at the end
of the buffer.
emacs/notmuch-show.el | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
--
1.7.8.3
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.
2012-01-31 8:01 [PATCH 0/2] adjust the new movement commands David Edmondson
@ 2012-01-31 8:01 ` David Edmondson
2012-01-31 8:09 ` Dmitry Kurochkin
2012-01-31 8:43 ` Tomi Ollila
2012-01-31 8:01 ` [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer David Edmondson
1 sibling, 2 replies; 17+ messages in thread
From: David Edmondson @ 2012-01-31 8:01 UTC (permalink / raw)
To: notmuch
When archiving the last message in a thread (a), rather than just
moving the pointer to the next thread in the parent search buffer,
actually display the next thread.
---
emacs/notmuch-show.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index de9421e..ec72ff8 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1427,7 +1427,7 @@ buffer."
(notmuch-show-mark-read)
(notmuch-show-message-adjust))
(if pop-at-end
- (notmuch-show-next-thread)
+ (notmuch-show-next-thread t)
(goto-char (point-max))))))
(defun notmuch-show-previous-open-message ()
--
1.7.8.3
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.
2012-01-31 8:01 [PATCH 0/2] adjust the new movement commands David Edmondson
2012-01-31 8:01 ` [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread David Edmondson
@ 2012-01-31 8:01 ` David Edmondson
2012-01-31 8:12 ` Dmitry Kurochkin
` (2 more replies)
1 sibling, 3 replies; 17+ messages in thread
From: David Edmondson @ 2012-01-31 8:01 UTC (permalink / raw)
To: notmuch
When using the spacebar to scroll through a thread, hitting 'space'
when the bottom of the last message is visible should take the cursor
to the end of the buffer rather than immediately archiving the thread
and moving to the next thread.
---
emacs/notmuch-show.el | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index ec72ff8..3f54de0 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1319,6 +1319,11 @@ current window), advance to the next open message."
;; This is not the last message - move to the next visible one.
(notmuch-show-next-open-message))
+ ((not (= (point) (point-max)))
+ ;; This is the last message, but the cursor is not at the end of
+ ;; the buffer. Move it there.
+ (goto-char (point-max)))
+
(t
;; This is the last message - change the return value
(setq ret t)))
--
1.7.8.3
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.
2012-01-31 8:01 ` [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread David Edmondson
@ 2012-01-31 8:09 ` Dmitry Kurochkin
2012-01-31 8:43 ` Tomi Ollila
1 sibling, 0 replies; 17+ messages in thread
From: Dmitry Kurochkin @ 2012-01-31 8:09 UTC (permalink / raw)
To: David Edmondson, notmuch
On Tue, 31 Jan 2012 08:01:53 +0000, David Edmondson <dme@dme.org> wrote:
> When archiving the last message in a thread (a), rather than just
> moving the pointer to the next thread in the parent search buffer,
> actually display the next thread.
> ---
+1
Regards,
Dmitry
> emacs/notmuch-show.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index de9421e..ec72ff8 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1427,7 +1427,7 @@ buffer."
> (notmuch-show-mark-read)
> (notmuch-show-message-adjust))
> (if pop-at-end
> - (notmuch-show-next-thread)
> + (notmuch-show-next-thread t)
> (goto-char (point-max))))))
>
> (defun notmuch-show-previous-open-message ()
> --
> 1.7.8.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.
2012-01-31 8:01 ` [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer David Edmondson
@ 2012-01-31 8:12 ` Dmitry Kurochkin
2012-01-31 8:22 ` David Edmondson
2012-01-31 8:40 ` Tomi Ollila
2012-04-15 17:14 ` Mark Walters
2 siblings, 1 reply; 17+ messages in thread
From: Dmitry Kurochkin @ 2012-01-31 8:12 UTC (permalink / raw)
To: David Edmondson, notmuch
On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson <dme@dme.org> wrote:
> When using the spacebar to scroll through a thread, hitting 'space'
> when the bottom of the last message is visible should take the cursor
> to the end of the buffer rather than immediately archiving the thread
> and moving to the next thread.
> ---
I did not notice this change yet, so +0
A style comment below.
> emacs/notmuch-show.el | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index ec72ff8..3f54de0 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1319,6 +1319,11 @@ current window), advance to the next open message."
> ;; This is not the last message - move to the next visible one.
> (notmuch-show-next-open-message))
>
> + ((not (= (point) (point-max)))
> + ;; This is the last message, but the cursor is not at the end of
> + ;; the buffer. Move it there.
> + (goto-char (point-max)))
Perhaps `unless' would be better here?
Regards,
Dmitry
> +
> (t
> ;; This is the last message - change the return value
> (setq ret t)))
> --
> 1.7.8.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.
2012-01-31 8:12 ` Dmitry Kurochkin
@ 2012-01-31 8:22 ` David Edmondson
2012-01-31 8:24 ` Dmitry Kurochkin
0 siblings, 1 reply; 17+ messages in thread
From: David Edmondson @ 2012-01-31 8:22 UTC (permalink / raw)
To: Dmitry Kurochkin, notmuch
[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]
On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson <dme@dme.org> wrote:
> > When using the spacebar to scroll through a thread, hitting 'space'
> > when the bottom of the last message is visible should take the cursor
> > to the end of the buffer rather than immediately archiving the thread
> > and moving to the next thread.
> > ---
>
> I did not notice this change yet, so +0
>
> A style comment below.
>
> > emacs/notmuch-show.el | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > index ec72ff8..3f54de0 100644
> > --- a/emacs/notmuch-show.el
> > +++ b/emacs/notmuch-show.el
> > @@ -1319,6 +1319,11 @@ current window), advance to the next open message."
> > ;; This is not the last message - move to the next visible one.
> > (notmuch-show-next-open-message))
> >
> > + ((not (= (point) (point-max)))
> > + ;; This is the last message, but the cursor is not at the end of
> > + ;; the buffer. Move it there.
> > + (goto-char (point-max)))
>
> Perhaps `unless' would be better here?
It's the CONDITION clause of `cond', so that wouldn't be appropriate.
> Regards,
> Dmitry
>
> > +
> > (t
> > ;; This is the last message - change the return value
> > (setq ret t)))
> > --
> > 1.7.8.3
> >
> > _______________________________________________
> > notmuch mailing list
> > notmuch@notmuchmail.org
> > http://notmuchmail.org/mailman/listinfo/notmuch
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.
2012-01-31 8:22 ` David Edmondson
@ 2012-01-31 8:24 ` Dmitry Kurochkin
2012-01-31 8:36 ` David Edmondson
0 siblings, 1 reply; 17+ messages in thread
From: Dmitry Kurochkin @ 2012-01-31 8:24 UTC (permalink / raw)
To: David Edmondson, notmuch
On Tue, 31 Jan 2012 08:22:20 +0000, David Edmondson <dme@dme.org> wrote:
> On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson <dme@dme.org> wrote:
> > > When using the spacebar to scroll through a thread, hitting 'space'
> > > when the bottom of the last message is visible should take the cursor
> > > to the end of the buffer rather than immediately archiving the thread
> > > and moving to the next thread.
> > > ---
> >
> > I did not notice this change yet, so +0
> >
> > A style comment below.
> >
> > > emacs/notmuch-show.el | 5 +++++
> > > 1 files changed, 5 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > > index ec72ff8..3f54de0 100644
> > > --- a/emacs/notmuch-show.el
> > > +++ b/emacs/notmuch-show.el
> > > @@ -1319,6 +1319,11 @@ current window), advance to the next open message."
> > > ;; This is not the last message - move to the next visible one.
> > > (notmuch-show-next-open-message))
> > >
> > > + ((not (= (point) (point-max)))
> > > + ;; This is the last message, but the cursor is not at the end of
> > > + ;; the buffer. Move it there.
> > > + (goto-char (point-max)))
> >
> > Perhaps `unless' would be better here?
>
> It's the CONDITION clause of `cond', so that wouldn't be appropriate.
>
oh
This is why I like big diff contexts...
Regards,
Dmitry
> > Regards,
> > Dmitry
> >
> > > +
> > > (t
> > > ;; This is the last message - change the return value
> > > (setq ret t)))
> > > --
> > > 1.7.8.3
> > >
> > > _______________________________________________
> > > notmuch mailing list
> > > notmuch@notmuchmail.org
> > > http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.
2012-01-31 8:24 ` Dmitry Kurochkin
@ 2012-01-31 8:36 ` David Edmondson
2012-01-31 8:39 ` Dmitry Kurochkin
0 siblings, 1 reply; 17+ messages in thread
From: David Edmondson @ 2012-01-31 8:36 UTC (permalink / raw)
To: Dmitry Kurochkin, notmuch
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
On Tue, 31 Jan 2012 12:24:27 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> This is why I like big diff contexts...
Can I set that in my .gitconfig?
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.
2012-01-31 8:36 ` David Edmondson
@ 2012-01-31 8:39 ` Dmitry Kurochkin
0 siblings, 0 replies; 17+ messages in thread
From: Dmitry Kurochkin @ 2012-01-31 8:39 UTC (permalink / raw)
To: David Edmondson, notmuch
On Tue, 31 Jan 2012 08:36:27 +0000, David Edmondson <dme@dme.org> wrote:
> On Tue, 31 Jan 2012 12:24:27 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > This is why I like big diff contexts...
>
> Can I set that in my .gitconfig?
Unfortunately, I did not find a way to do that, except for adding an
alias. But that is a poor solution. So I add -U20 parameter manually
for some patches.
Regards,
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.
2012-01-31 8:01 ` [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer David Edmondson
2012-01-31 8:12 ` Dmitry Kurochkin
@ 2012-01-31 8:40 ` Tomi Ollila
2012-04-15 17:14 ` Mark Walters
2 siblings, 0 replies; 17+ messages in thread
From: Tomi Ollila @ 2012-01-31 8:40 UTC (permalink / raw)
To: David Edmondson, notmuch
On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson <dme@dme.org> wrote:
> When using the spacebar to scroll through a thread, hitting 'space'
> when the bottom of the last message is visible should take the cursor
> to the end of the buffer rather than immediately archiving the thread
> and moving to the next thread.
> ---
+1 !
Tomi
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.
2012-01-31 8:01 ` [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread David Edmondson
2012-01-31 8:09 ` Dmitry Kurochkin
@ 2012-01-31 8:43 ` Tomi Ollila
2012-01-31 8:51 ` Dmitry Kurochkin
1 sibling, 1 reply; 17+ messages in thread
From: Tomi Ollila @ 2012-01-31 8:43 UTC (permalink / raw)
To: David Edmondson, notmuch
On Tue, 31 Jan 2012 08:01:53 +0000, David Edmondson <dme@dme.org> wrote:
> When archiving the last message in a thread (a), rather than just
> moving the pointer to the next thread in the parent search buffer,
> actually display the next thread.
> ---
-1. Magic! Rather some customization option which lets user choose
consistent behaviour (i.e. 'a' either jumps to search buffer or
goes to next thread always (default?)).
Tomi
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.
2012-01-31 8:43 ` Tomi Ollila
@ 2012-01-31 8:51 ` Dmitry Kurochkin
2012-01-31 9:25 ` Tomi Ollila
0 siblings, 1 reply; 17+ messages in thread
From: Dmitry Kurochkin @ 2012-01-31 8:51 UTC (permalink / raw)
To: Tomi Ollila, David Edmondson, notmuch
On Tue, 31 Jan 2012 10:43:10 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Tue, 31 Jan 2012 08:01:53 +0000, David Edmondson <dme@dme.org> wrote:
> > When archiving the last message in a thread (a), rather than just
> > moving the pointer to the next thread in the parent search buffer,
> > actually display the next thread.
> > ---
>
> -1. Magic! Rather some customization option which lets user choose
> consistent behaviour (i.e. 'a' either jumps to search buffer or
> goes to next thread always (default?)).
>
FWIW this behavior is consistent with how archiving worked before
earlier today. For those who uses archiving, the new behavior is a
surprise. So I would argue that this patch makes it less "magic". And
consistent with the current "A" behavior.
Regards,
Dmitry
> Tomi
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.
2012-01-31 8:51 ` Dmitry Kurochkin
@ 2012-01-31 9:25 ` Tomi Ollila
2012-01-31 10:30 ` David Edmondson
0 siblings, 1 reply; 17+ messages in thread
From: Tomi Ollila @ 2012-01-31 9:25 UTC (permalink / raw)
To: Dmitry Kurochkin, David Edmondson, notmuch
On Tue, 31 Jan 2012 12:51:44 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> On Tue, 31 Jan 2012 10:43:10 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> > On Tue, 31 Jan 2012 08:01:53 +0000, David Edmondson <dme@dme.org> wrote:
> > > When archiving the last message in a thread (a), rather than just
> > > moving the pointer to the next thread in the parent search buffer,
> > > actually display the next thread.
> > > ---
> >
> > -1. Magic! Rather some customization option which lets user choose
> > consistent behaviour (i.e. 'a' either jumps to search buffer or
> > goes to next thread always (default?)).
> >
>
> FWIW this behavior is consistent with how archiving worked before
> earlier today. For those who uses archiving, the new behavior is a
> surprise. So I would argue that this patch makes it less "magic". And
> consistent with the current "A" behavior.
Yes, I had a thinko there. 'a' progresses to next message after archiving
and not back to search buffer...
I like David's alternative suggestion (in IRC) where cursor is left at
the end of buffer in case last message is archived with 'a'.
> Regards,
> Dmitry
Thanks,
Tomi
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.
2012-01-31 9:25 ` Tomi Ollila
@ 2012-01-31 10:30 ` David Edmondson
2012-01-31 10:55 ` Tomi Ollila
0 siblings, 1 reply; 17+ messages in thread
From: David Edmondson @ 2012-01-31 10:30 UTC (permalink / raw)
To: Tomi Ollila, Dmitry Kurochkin, notmuch
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
On Tue, 31 Jan 2012 11:25:36 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> I like David's alternative suggestion (in IRC) where cursor is left at
> the end of buffer in case last message is archived with 'a'.
Unless the cursor is already at the end of the buffer, in which case it
would do the 'next thread' dance (i.e. it behaves like 'space' in that
respect).
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread.
2012-01-31 10:30 ` David Edmondson
@ 2012-01-31 10:55 ` Tomi Ollila
0 siblings, 0 replies; 17+ messages in thread
From: Tomi Ollila @ 2012-01-31 10:55 UTC (permalink / raw)
To: David Edmondson, Dmitry Kurochkin, notmuch
On Tue, 31 Jan 2012 10:30:20 +0000, David Edmondson <dme@dme.org> wrote:
> On Tue, 31 Jan 2012 11:25:36 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> > I like David's alternative suggestion (in IRC) where cursor is left at
> > the end of buffer in case last message is archived with 'a'.
>
> Unless the cursor is already at the end of the buffer, in which case it
> would do the 'next thread' dance (i.e. it behaves like 'space' in that
> respect).
I think I (and Jameson) don't want that behaviour -- therefore we need
functionality (somewhat) analogous to this:
(defun notmuch-show-advance-and-archive ()
"..."
(interactive)
(if (notmuch-show-advance)
(notmuch-show-archive-thread-then-next)))
So we can easily rebind to the version which doesn't
do the '...then-next' magic...
Tomi
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.
2012-01-31 8:01 ` [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer David Edmondson
2012-01-31 8:12 ` Dmitry Kurochkin
2012-01-31 8:40 ` Tomi Ollila
@ 2012-04-15 17:14 ` Mark Walters
2012-04-15 17:33 ` Tomi Ollila
2 siblings, 1 reply; 17+ messages in thread
From: Mark Walters @ 2012-04-15 17:14 UTC (permalink / raw)
To: David Edmondson, notmuch
On Tue, 31 Jan 2012, David Edmondson <dme@dme.org> wrote:
> When using the spacebar to scroll through a thread, hitting 'space'
> when the bottom of the last message is visible should take the cursor
> to the end of the buffer rather than immediately archiving the thread
> and moving to the next thread.
Hi
This patch looks good to me; (but if people prefer the current behaviour then
can we mark this notmuch::wontfix so it leaves the review queue)
Best wishes
Mark
> ---
> emacs/notmuch-show.el | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index ec72ff8..3f54de0 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1319,6 +1319,11 @@ current window), advance to the next open message."
> ;; This is not the last message - move to the next visible one.
> (notmuch-show-next-open-message))
>
> + ((not (= (point) (point-max)))
> + ;; This is the last message, but the cursor is not at the end of
> + ;; the buffer. Move it there.
> + (goto-char (point-max)))
> +
> (t
> ;; This is the last message - change the return value
> (setq ret t)))
> --
> 1.7.8.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.
2012-04-15 17:14 ` Mark Walters
@ 2012-04-15 17:33 ` Tomi Ollila
0 siblings, 0 replies; 17+ messages in thread
From: Tomi Ollila @ 2012-04-15 17:33 UTC (permalink / raw)
To: Mark Walters, David Edmondson, notmuch
On Sun, Apr 15 2012, Mark Walters wrote:
> On Tue, 31 Jan 2012, David Edmondson <dme@dme.org> wrote:
>> When using the spacebar to scroll through a thread, hitting 'space'
>> when the bottom of the last message is visible should take the cursor
>> to the end of the buffer rather than immediately archiving the thread
>> and moving to the next thread.
>
> Hi
>
> This patch looks good to me; (but if people prefer the current behaviour then
> can we mark this notmuch::wontfix so it leaves the review queue)
I would definitely like to see this patch applied. Less surprising
as there is no indication we have reached the bottom of the buffer.
> Best wishes
>
> Mark
Tomi
>
>> ---
>> emacs/notmuch-show.el | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
>> index ec72ff8..3f54de0 100644
>> --- a/emacs/notmuch-show.el
>> +++ b/emacs/notmuch-show.el
>> @@ -1319,6 +1319,11 @@ current window), advance to the next open message."
>> ;; This is not the last message - move to the next visible one.
>> (notmuch-show-next-open-message))
>>
>> + ((not (= (point) (point-max)))
>> + ;; This is the last message, but the cursor is not at the end of
>> + ;; the buffer. Move it there.
>> + (goto-char (point-max)))
>> +
>> (t
>> ;; This is the last message - change the return value
>> (setq ret t)))
>> --
>> 1.7.8.3
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2012-04-15 17:33 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-31 8:01 [PATCH 0/2] adjust the new movement commands David Edmondson
2012-01-31 8:01 ` [PATCH 1/2] emacs: If archiving the last message in a thread, show the next thread David Edmondson
2012-01-31 8:09 ` Dmitry Kurochkin
2012-01-31 8:43 ` Tomi Ollila
2012-01-31 8:51 ` Dmitry Kurochkin
2012-01-31 9:25 ` Tomi Ollila
2012-01-31 10:30 ` David Edmondson
2012-01-31 10:55 ` Tomi Ollila
2012-01-31 8:01 ` [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer David Edmondson
2012-01-31 8:12 ` Dmitry Kurochkin
2012-01-31 8:22 ` David Edmondson
2012-01-31 8:24 ` Dmitry Kurochkin
2012-01-31 8:36 ` David Edmondson
2012-01-31 8:39 ` Dmitry Kurochkin
2012-01-31 8:40 ` Tomi Ollila
2012-04-15 17:14 ` Mark Walters
2012-04-15 17:33 ` Tomi Ollila
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).