Re: [PATCH] nntp: delimit Newsgroup: header with commas

[Andrey Melnikov <temnota.am@gmail.com>]

чт, 5 нояб. 2020 г. в 10:50, Eric Wong <e@80x24.org>:
>

[...]

> > Haha. It simply does not expect folded multiline Xref:  header. And
> > generate by itself a new (unfolded, separated by space) header when
> > storing article on disk.
> > Is really Newsgroups: & Xref: headers need folding?
>
> Nope, but currently PublicInbox::Eml folds by default
> (and Email::MIME/Email::Simple did in ->as_string, too).
>
> I didn't expect clients to have problems with folded lines since
> Received: and Cc: are often folded, anyways.
>
> Does leafnode struggle with those headers?  Or just Newsgroups/Xref?

There are two versions of leafnode - leafnode1 (1.11.11) and leafnode2
(2.0.0.alpha20140727b).
The first version correctly parses headers (it knows about folding),
the second version - not. At least Xref: is affected. Newsgroups:
header is expected to be folded.

> We may need a separate API method for setting NNTP-only headers
> to appease leafnode...
Or write in docs a big fat warning about using leafnode2.

> > > > and new:
> > > > Path: nntp.lore.kernel.org!not.for.mail
> > > > save more extra bytes...
> > > >
> > > > Hehe... yet another cosmetic thing:
> > > > $ telnet nntp.lore.kernel.org 119
> > > > Trying 54.189.247.149...
> > > > Connected to korg-lkml-1-news-lb-839eef9f3a4cef4e.elb.us-west-2.amazonaws.com.
> > > > Escape character is '^]'.
> > > > 201 nntp://nntp.lore.kernel.org ready - post via email
> > > > quit
> > > > Connection closed by foreign host.
> > > >
> > > > 'nntp://nntp.lore.kernel.org' is not a node name per RFC... But this
> > > > is a configuration problem on nntp.lore.kernel.org side.
> > >
> > > You can notify helpdesk@kernel.org to get it fixed.
> >
> > This is cosmetics. nntp readers do not use this hostname.
>
> It may be nice to extract hostname from URI, anyways, since it
> should be possible to advertise NNTPS endpoint in the WWW UI.
=~ s|[^:]+://||; ?