From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 463841F66F for ; Fri, 6 Nov 2020 11:57:47 +0000 (UTC) Received: by mail-il1-x131.google.com with SMTP id n5so830526ile.7 for ; Fri, 06 Nov 2020 03:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=o1qTxB6mzYIySxIwjxpbtrMwCqBwumuK1ZLXSomp5UQ=; b=S480RGIy2GknVUSAuZk5VGrzqcrIEll+Y/GLupB2W+HlR4olpGBWy2RCIshKXxKnf4 htEz9570BoEV9e8kuyLPzvejgi6ts0XdqiNUvsuJcTJ5w88Fb7mL5TGJQqWO3x0C0JFG sf5G+pKvXDgHVfrv6+REbC1I2m6gxR69POF2EtKEtL+7a6lIBalWVOC/T0gUws01tBmQ ez6aupuziYaURt3oXUSGD05b/VaKbRm4o0BnBBPAqAHaieXVn6Mk4acre75h/USvMoW7 5Etf3ZBX4vqehwMWmGUv/gQ/74O9MbKCpoej6eLhEPH5F3RqAp5xrcuiTPySg2tiWxAV /1vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=o1qTxB6mzYIySxIwjxpbtrMwCqBwumuK1ZLXSomp5UQ=; b=H+2S0Q8KBCnKvRgi6/QPANy7NXm0O6CvYa5w24ZvN8HN2tkxbArI3uBu1UeB66z0bS vkVwGFce2Pt2BlKhHHZFJ4JlDiyA5ELBzcwKd3KqDJ9pKZcvmLrk9VWkUKadG+Sw83tO yBpcL93gZOBW/I9raSOpxwyW+fJonn8MoT0+WdmJLQ9z50SGoPm9QKaR1p2Rbo2srgDd ilcg7wfFFYZWkMkiymqhLCj7aOY01tLvaqrLt9tsxhoKvr3QirNOnRhDhRFvtEYRW3fr QDfj+0BMl8gH47jkz6tO3+XIV3BWw+FhqFOmNOvGOEK+Y9YmxbpX/Q9ZnK8K5jkcl71z NZJg== X-Gm-Message-State: AOAM5339GMCg6IGQsYOn/PDKRXXZ8fhNKhIHAScH+kaZ0AE480mJ6qhY g8O93OmGT+5e1Dr+mAXHcoKw2wJqJ26w49+GzVE= X-Google-Smtp-Source: ABdhPJzZdfJdrLrGE38wrlHB3my6GjNlggqMaV7DBJKgSNeErvwusYF2wOqbvkHpLpSm7ulC24Be6RG5AXc67m/lq7Y= X-Received: by 2002:a05:6e02:df1:: with SMTP id m17mr1099908ilj.70.1604663866288; Fri, 06 Nov 2020 03:57:46 -0800 (PST) MIME-Version: 1.0 References: <20201103225559.GA5247@dcvr> <20201103235942.GA6163@dcvr> <20201104104448.GA6053@dcvr> <20201104194706.GA24387@dcvr> <20201105075021.GA83277@dcvr> In-Reply-To: <20201105075021.GA83277@dcvr> From: Andrey Melnikov Date: Fri, 6 Nov 2020 14:57:34 +0300 Message-ID: Subject: Re: [PATCH] nntp: delimit Newsgroup: header with commas To: Eric Wong Cc: meta@public-inbox.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: =D1=87=D1=82, 5 =D0=BD=D0=BE=D1=8F=D0=B1. 2020 =D0=B3. =D0=B2 10:50, Eric W= ong : > [...] > > Haha. It simply does not expect folded multiline Xref: header. And > > generate by itself a new (unfolded, separated by space) header when > > storing article on disk. > > Is really Newsgroups: & Xref: headers need folding? > > Nope, but currently PublicInbox::Eml folds by default > (and Email::MIME/Email::Simple did in ->as_string, too). > > I didn't expect clients to have problems with folded lines since > Received: and Cc: are often folded, anyways. > > Does leafnode struggle with those headers? Or just Newsgroups/Xref? There are two versions of leafnode - leafnode1 (1.11.11) and leafnode2 (2.0.0.alpha20140727b). The first version correctly parses headers (it knows about folding), the second version - not. At least Xref: is affected. Newsgroups: header is expected to be folded. > We may need a separate API method for setting NNTP-only headers > to appease leafnode... Or write in docs a big fat warning about using leafnode2. > > > > and new: > > > > Path: nntp.lore.kernel.org!not.for.mail > > > > save more extra bytes... > > > > > > > > Hehe... yet another cosmetic thing: > > > > $ telnet nntp.lore.kernel.org 119 > > > > Trying 54.189.247.149... > > > > Connected to korg-lkml-1-news-lb-839eef9f3a4cef4e.elb.us-west-2.ama= zonaws.com. > > > > Escape character is '^]'. > > > > 201 nntp://nntp.lore.kernel.org ready - post via email > > > > quit > > > > Connection closed by foreign host. > > > > > > > > 'nntp://nntp.lore.kernel.org' is not a node name per RFC... But thi= s > > > > is a configuration problem on nntp.lore.kernel.org side. > > > > > > You can notify helpdesk@kernel.org to get it fixed. > > > > This is cosmetics. nntp readers do not use this hostname. > > It may be nice to extract hostname from URI, anyways, since it > should be possible to advertise NNTPS endpoint in the WWW UI. =3D~ s|[^:]+://||; ?