* [PATCH] www: speed up global manifest.js.gz w/ "all" extindex
@ 2024-04-08 9:49 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2024-04-08 9:49 UTC (permalink / raw)
To: meta
By reducing internal event loop iterations, this brings 300+
inboxes down ~32ms to ~27ms. It should also be more consistent
on servers with busy event loops since all the Xapian DB traffic
happens at once, theoretically mproving cache utilization.
---
lib/PublicInbox/ConfigIter.pm | 7 +++----
lib/PublicInbox/ManifestJsGz.pm | 5 +++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/ConfigIter.pm b/lib/PublicInbox/ConfigIter.pm
index 14fcef83..f9e3451a 100644
--- a/lib/PublicInbox/ConfigIter.pm
+++ b/lib/PublicInbox/ConfigIter.pm
@@ -1,12 +1,11 @@
-# Copyright (C) 2020-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
# Intended for PublicInbox::DS::event_loop in read-only daemons
# to avoid each_inbox() monopolizing the event loop when hundreds/thousands
# of inboxes are in play.
package PublicInbox::ConfigIter;
-use strict;
-use v5.10.1;
+use v5.12;
sub new {
my ($class, $pi_cfg, $cb, @args) = @_;
@@ -25,7 +24,7 @@ sub event_step {
PublicInbox::DS::requeue($self) if defined($section);
}
-# for generic PSGI servers
+# for generic PSGI servers, but also ManifestJsGz w/ ALL extindex
sub each_section {
my $self = shift;
my ($pi_cfg, $i, $cb, @arg) = @$self;
diff --git a/lib/PublicInbox/ManifestJsGz.pm b/lib/PublicInbox/ManifestJsGz.pm
index 1f739baa..be5d5f2a 100644
--- a/lib/PublicInbox/ManifestJsGz.pm
+++ b/lib/PublicInbox/ManifestJsGz.pm
@@ -82,8 +82,9 @@ sub response {
$ctx->can('list_match_i'), $re, $ctx);
sub {
$ctx->{-wcb} = $_[0]; # HTTP server callback
- $ctx->{env}->{'pi-httpd.async'} ?
- $iter->event_step : $iter->each_section;
+ ($ctx->{www}->{pi_cfg}->ALL ||
+ !$ctx->{env}->{'pi-httpd.async'}) ?
+ $iter->each_section : $iter->event_step;
}
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-08 9:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-08 9:49 [PATCH] www: speed up global manifest.js.gz w/ "all" extindex Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).