unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] listener: don't loop on errors
@ 2024-03-11 10:06 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2024-03-11 10:06 UTC (permalink / raw)
  To: meta

Fortunately, this only affects `--multi-accept=' users, with
`--multi-accept=-1' users getting infinite loops.

I noticed this when EMFILE was reached on my setup, but any
error should cause us to give up accept(2) (at least
temporarily) and allow work for other items in the event loop to
be processed.
---
 lib/PublicInbox/Listener.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Listener.pm b/lib/PublicInbox/Listener.pm
index 4669cf04..c83901b2 100644
--- a/lib/PublicInbox/Listener.pm
+++ b/lib/PublicInbox/Listener.pm
@@ -41,9 +41,9 @@ sub event_step {
 			# ECONNABORTED is common with bad connections
 			return;
 		} elsif (my $sym = $ERR_WARN{int($!)}) {
-			warn "W: accept(): $! ($sym)\n";
+			return warn "W: accept(): $! ($sym)\n";
 		} else {
-			warn "BUG?: accept(): $!\n";
+			return warn "BUG?: accept(): $!\n";
 		}
 	} while ($n--);
 }

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2024-03-11 10:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-11 10:06 [PATCH] listener: don't loop on errors Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).