[PATCH] t/nntpd-tls: avoid test failure on OpenBSD 7.3

[PATCH] t/nntpd-tls: avoid test failure on OpenBSD 7.3

[Eric Wong]

The LibreSSL 3.7.2 on my OpenBSD 7.3 VM seems return 7 bytes of
junk data before EOF/ECONNRESET when a client attempts to write
plain-text to a TLS socket.
---
 t/nntpd-tls.t | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/t/nntpd-tls.t b/t/nntpd-tls.t
index a11a0dd9..a16cc015 100644
--- a/t/nntpd-tls.t
+++ b/t/nntpd-tls.t
@@ -187,8 +187,12 @@ for my $args (
 
 	my $s = tcp_connect($nntps);
 	syswrite($s, '->accept_SSL_ will fail on this!');
-	ok(!sysread($s, my $rbuf, 128), 'EOF or ECONNRESET on ->accept_SSL fail');
-
+	my @r;
+	do { # some platforms or OpenSSL versions need an extra read
+		push @r, sysread($s, my $rbuf, 128);
+	} while ($r[-1] && @r < 2);
+	ok(!$r[-1], 'EOF or ECONNRESET on ->accept_SSL fail') or
+		diag explain(\@r);
 	$c = undef;
 	$td->kill;
 	$td->join;

Re: [PATCH] t/nntpd-tls: avoid test failure on OpenBSD 7.3

[Štěpán Němec]

On Mon, 27 Nov 2023 07:26:28 +0000
Eric Wong wrote:

> The LibreSSL 3.7.2 on my OpenBSD 7.3 VM seems return 7 bytes of
> junk data before EOF/ECONNRESET when a client attempts to write
> plain-text to a TLS socket.

I can confirm this patch fixes the failure on a month-old
-current with LibreSSL 3.8.2 as well.

I was going to report this at some point, but kept putting
it off (there had been some other intermittent test failures
during the recent refactorings, but not for some weeks now).

Thanks,

  Štěpán