unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH 00/14] IO/IPC-related cleanups
@ 2023-11-02  9:35 Eric Wong
  2023-11-02  9:35 ` [PATCH 01/14] xap_helper.pm: use do_fork to Reset and reseed Eric Wong
                   ` (13 more replies)
  0 siblings, 14 replies; 17+ messages in thread
From: Eric Wong @ 2023-11-02  9:35 UTC (permalink / raw)
  To: meta

8/14 to replace ProcessIO is a major change that I've been
hammering away at for a bit, and many preceding patches to
eliminate ->close calls make it easier to review.

11-12/14 - Error checking for buffered readline is a PITA
(IO::Handle->error was insufficient until Perl 5.34), and I may
switch to sysread eventually to avoid the double-copy overhead
of buffered bulk I/O, anyways.  The only place we really benefit
from userspace buffered disk reads is IdxStack, I think...

The new write_file sub in 9/14 seems long overdue.

Eric Wong (14):
  xap_helper.pm: use do_fork to Reset and reseed
  ds: replace FD map hash table with array
  treewide: use ->close method rather than CORE::close
  cindex: drop redundant close on regular FH
  treewide: use ->close to call ProcessIO->CLOSE
  multi_git: use autodie
  git_credential: use autodie where appropriate
  replace ProcessIO with untied PublicInbox::IO
  io: introduce write_file helper sub
  spawn: support PerlIO layer in scalar redirects
  treewide: check alternates writes with eof + autodie
  treewide: use eof and close to detect readline errors
  move read_all, try_cat, and poll_in to PublicInbox::IO
  t/cindex+extsearch: use write_file, autodie, etc.

 MANIFEST                         |  4 +-
 lib/PublicInbox/CodeSearchIdx.pm | 14 +++---
 lib/PublicInbox/Config.pm        |  2 +-
 lib/PublicInbox/DS.pm            | 22 ++++-----
 lib/PublicInbox/DirIdle.pm       |  2 +-
 lib/PublicInbox/Gcf2.pm          |  4 +-
 lib/PublicInbox/Gcf2Client.pm    |  7 ++-
 lib/PublicInbox/Git.pm           | 36 ++++----------
 lib/PublicInbox/GitCredential.pm | 16 +++----
 lib/PublicInbox/HTTP.pm          |  4 +-
 lib/PublicInbox/IO.pm            | 80 ++++++++++++++++++++++++++++++++
 lib/PublicInbox/IdxStack.pm      |  2 +-
 lib/PublicInbox/Import.pm        | 18 ++++---
 lib/PublicInbox/Inbox.pm         |  2 +-
 lib/PublicInbox/InboxWritable.pm |  2 +-
 lib/PublicInbox/InputPipe.pm     |  1 -
 lib/PublicInbox/LEI.pm           |  8 ++--
 lib/PublicInbox/LeiALE.pm        |  6 +--
 lib/PublicInbox/LeiBlob.pm       |  3 +-
 lib/PublicInbox/LeiConfig.pm     |  2 +-
 lib/PublicInbox/LeiInput.pm      |  5 +-
 lib/PublicInbox/LeiMailSync.pm   |  3 +-
 lib/PublicInbox/LeiMirror.pm     | 57 +++++++++--------------
 lib/PublicInbox/LeiRediff.pm     | 11 ++---
 lib/PublicInbox/LeiStoreErr.pm   |  2 +-
 lib/PublicInbox/LeiSucks.pm      |  2 +-
 lib/PublicInbox/LeiToMail.pm     | 34 +++++++-------
 lib/PublicInbox/LeiViewText.pm   |  2 +-
 lib/PublicInbox/LeiXSearch.pm    |  8 ++--
 lib/PublicInbox/MailDiff.pm      | 21 ++++-----
 lib/PublicInbox/MboxReader.pm    |  4 +-
 lib/PublicInbox/MultiGit.pm      | 13 +++---
 lib/PublicInbox/ProcessIO.pm     | 75 ------------------------------
 lib/PublicInbox/ProcessIONBF.pm  | 25 ----------
 lib/PublicInbox/Qspawn.pm        |  5 +-
 lib/PublicInbox/SearchIdx.pm     |  4 +-
 lib/PublicInbox/SolverGit.pm     | 38 ++++++---------
 lib/PublicInbox/Spawn.pm         | 42 ++++++++++-------
 lib/PublicInbox/TestCommon.pm    |  4 +-
 lib/PublicInbox/V2Writable.pm    |  2 +-
 lib/PublicInbox/ViewVCS.pm       |  6 +--
 lib/PublicInbox/WWW.pm           |  2 +-
 lib/PublicInbox/XapHelper.pm     | 14 ++----
 lib/PublicInbox/XapHelperCxx.pm  |  3 +-
 script/public-inbox-convert      |  6 +--
 script/public-inbox-edit         |  3 +-
 script/public-inbox-init         |  4 +-
 t/cindex.t                       | 17 ++-----
 t/clone-coderepo.t               | 10 ++--
 t/extsearch.t                    | 48 ++++++-------------
 t/httpd-corner.t                 |  2 +-
 t/init.t                         |  2 +-
 t/io.t                           | 33 +++++++++++++
 t/lei-mirror.t                   | 10 ++--
 t/lei-q-kw.t                     |  4 +-
 t/spawn.t                        | 36 +++++++-------
 xt/check-run.t                   |  2 +-
 xt/git_async_cmp.t               |  4 +-
 xt/httpd-async-stream.t          |  2 +-
 59 files changed, 368 insertions(+), 432 deletions(-)
 create mode 100644 lib/PublicInbox/IO.pm
 delete mode 100644 lib/PublicInbox/ProcessIO.pm
 delete mode 100644 lib/PublicInbox/ProcessIONBF.pm
 create mode 100644 t/io.t

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2023-11-02 21:35 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-02  9:35 [PATCH 00/14] IO/IPC-related cleanups Eric Wong
2023-11-02  9:35 ` [PATCH 01/14] xap_helper.pm: use do_fork to Reset and reseed Eric Wong
2023-11-02  9:35 ` [PATCH 02/14] ds: replace FD map hash table with array Eric Wong
2023-11-02  9:35 ` [PATCH 03/14] treewide: use ->close method rather than CORE::close Eric Wong
2023-11-02 21:35   ` [PATCH 15/14] ds: don't try ->close after ->accept_SSL failure Eric Wong
2023-11-02  9:35 ` [PATCH 04/14] cindex: drop redundant close on regular FH Eric Wong
2023-11-02  9:35 ` [PATCH 05/14] treewide: use ->close to call ProcessIO->CLOSE Eric Wong
2023-11-02  9:35 ` [PATCH 06/14] multi_git: use autodie Eric Wong
2023-11-02  9:35 ` [PATCH 07/14] git_credential: use autodie where appropriate Eric Wong
2023-11-02  9:35 ` [PATCH 08/14] replace ProcessIO with untied PublicInbox::IO Eric Wong
2023-11-02  9:35 ` [PATCH 09/14] io: introduce write_file helper sub Eric Wong
2023-11-02  9:35 ` [PATCH 10/14] spawn: support PerlIO layer in scalar redirects Eric Wong
2023-11-02  9:35 ` [PATCH 11/14] treewide: check alternates writes with eof + autodie Eric Wong
2023-11-02  9:35 ` [PATCH 12/14] treewide: use eof and close to detect readline errors Eric Wong
2023-11-02  9:35 ` [PATCH 13/14] move read_all, try_cat, and poll_in to PublicInbox::IO Eric Wong
2023-11-02 20:59   ` www: squash read_all usage fix Eric Wong
2023-11-02  9:35 ` [PATCH 14/14] t/cindex+extsearch: use write_file, autodie, etc Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).