unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: "Štěpán Němec" <stepnem@smrk.net>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 1/3] doc: fix some typos and grammar
Date: Mon, 16 Oct 2023 21:13:20 +0000	[thread overview]
Message-ID: <20231016211320.M268439@dcvr> (raw)
In-Reply-To: <20231016113304.2788497-1-stepnem@smrk.net>

Štěpán Němec <stepnem@smrk.net> wrote:
>  Documentation/RelNotes/v1.9.0.eml        | 2 +-
>  Documentation/RelNotes/v2.0.0.wip        | 6 +++---
>  Documentation/lei-config.pod             | 8 ++++----
>  Documentation/lei-daemon-kill.pod        | 2 +-
>  Documentation/lei-inspect.pod            | 4 ++--
>  Documentation/lei-lcat.pod               | 2 +-
>  Documentation/lei-ls-mail-source.pod     | 2 +-
>  Documentation/lei-ls-search.pod          | 2 +-
>  Documentation/lei-mail-sync-overview.pod | 2 +-
>  Documentation/lei-q.pod                  | 4 ++--
>  Documentation/lei-security.pod           | 8 ++++----
>  Documentation/lei-store-format.pod       | 2 +-
>  Documentation/lei-up.pod                 | 4 ++--

Thanks, changes to those files look fine (but I'm no English
expert, either).  My brain does jumble words often :x

> diff --git a/TODO b/TODO
> index de628e2e310a..36a7f0cf441a 100644
> --- a/TODO
> +++ b/TODO
> @@ -26,7 +26,7 @@ all need to be considered for everything we introduce.)
>    archive locations to avoid SPOF.
>  
>  * optional Cache::FastMmap support so production deployments won't
> -  need Varnish (Varnish doesn't protect NNTP nor IMAP, either)
> +  need Varnish (Varnish doesn't protect NNTP or IMAP, either)

I'm not sure about this change, I seem to remember `nor' being
more suited for negatives.  Any citations or comments from
others reading this?

>  * dogfood and take advantage of new kernel APIs (while maintaining
>    portability to older Linux, free BSDs and maybe Hurd).
> diff --git a/install/README b/install/README
> index 981e014b9959..e1b5558e0b87 100644
> --- a/install/README
> +++ b/install/README
> @@ -5,7 +5,7 @@ TL;DR:	sudo ./install/deps.perl all
>  
>  Files in this directory are designed for:
>  
> -* users using from git or tarballs (and not the OS package manager)
> +* users using git repo or tarballs (and not the OS package manager)

I wonder if:

  * users using our code from git or tarballs (and not the OS package manager)

...is better.  I always feel the need to clarify git the software
vs. our code repo vs. our mirror on public-inbox.org/git   *shrug*

> --- a/lib/PublicInbox/XapHelperCxx.pm
> +++ b/lib/PublicInbox/XapHelperCxx.pm
> @@ -36,7 +36,7 @@ sub xap_cfg (@) {
>  	seek($err, 0, SEEK_SET) or die "seek: $!";
>  	$err = do { local $/; <$err> };
>  	die <<EOM;
> -@$cmd failed: Xapian devlopment files missing? (\$?=$?)
> +@$cmd failed: Xapian development files missing? (\$?=$?)

Yup, I also just noticed that on a different branch I'm been working on.

  parent reply	other threads:[~2023-10-16 21:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 11:33 [PATCH 1/3] doc: fix some typos and grammar Štěpán Němec
2023-10-16 11:33 ` [PATCH 2/3] doc: lei-q: drop stale TODO comment (fixed in 1f1b1f0e22f7) Štěpán Němec
2023-10-16 21:17   ` Eric Wong
2023-10-16 11:33 ` [PATCH 3/3] search: rectify comment (rt: documented since 738c4a65719e) Štěpán Němec
2023-10-16 21:39   ` Eric Wong
2023-10-16 21:13 ` Eric Wong [this message]
2023-10-16 22:16   ` [PATCH 1/3] doc: fix some typos and grammar Štěpán Němec
2023-10-17  6:43     ` [PATCH 4/3] install/README: improve wording Eric Wong
2023-10-17  7:19       ` Štěpán Němec
2023-10-17  7:54         ` Eric Wong
2023-10-17  8:07           ` Štěpán Němec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231016211320.M268439@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --cc=stepnem@smrk.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).