From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 8D15C1F406; Mon, 16 Oct 2023 21:14:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1697490873; bh=wjWObhX1gTxXRbM05xF0CoJshFY74BHZkMwITFfec54=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IEmYzDZIvmUS8TV2EvvA6iK2Pz7eX4ErV2BN9n0Fi1amn8O916motP25TTGEy6ixh xeKKZ0MUc/ezcCUSnJLrOvHQw1FLCmel3mWXdicz5qhWZPC5dpMd23/BxMxV8tHyME Ba3EuH4AgXzgJ0Q0jtCXOEW9cOUPaer9miUuS454= Date: Mon, 16 Oct 2023 21:13:20 +0000 From: Eric Wong To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= Cc: meta@public-inbox.org Subject: Re: [PATCH 1/3] doc: fix some typos and grammar Message-ID: <20231016211320.M268439@dcvr> References: <20231016113304.2788497-1-stepnem@smrk.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231016113304.2788497-1-stepnem@smrk.net> List-Id: Štěpán Němec wrote: > Documentation/RelNotes/v1.9.0.eml | 2 +- > Documentation/RelNotes/v2.0.0.wip | 6 +++--- > Documentation/lei-config.pod | 8 ++++---- > Documentation/lei-daemon-kill.pod | 2 +- > Documentation/lei-inspect.pod | 4 ++-- > Documentation/lei-lcat.pod | 2 +- > Documentation/lei-ls-mail-source.pod | 2 +- > Documentation/lei-ls-search.pod | 2 +- > Documentation/lei-mail-sync-overview.pod | 2 +- > Documentation/lei-q.pod | 4 ++-- > Documentation/lei-security.pod | 8 ++++---- > Documentation/lei-store-format.pod | 2 +- > Documentation/lei-up.pod | 4 ++-- Thanks, changes to those files look fine (but I'm no English expert, either). My brain does jumble words often :x > diff --git a/TODO b/TODO > index de628e2e310a..36a7f0cf441a 100644 > --- a/TODO > +++ b/TODO > @@ -26,7 +26,7 @@ all need to be considered for everything we introduce.) > archive locations to avoid SPOF. > > * optional Cache::FastMmap support so production deployments won't > - need Varnish (Varnish doesn't protect NNTP nor IMAP, either) > + need Varnish (Varnish doesn't protect NNTP or IMAP, either) I'm not sure about this change, I seem to remember `nor' being more suited for negatives. Any citations or comments from others reading this? > * dogfood and take advantage of new kernel APIs (while maintaining > portability to older Linux, free BSDs and maybe Hurd). > diff --git a/install/README b/install/README > index 981e014b9959..e1b5558e0b87 100644 > --- a/install/README > +++ b/install/README > @@ -5,7 +5,7 @@ TL;DR: sudo ./install/deps.perl all > > Files in this directory are designed for: > > -* users using from git or tarballs (and not the OS package manager) > +* users using git repo or tarballs (and not the OS package manager) I wonder if: * users using our code from git or tarballs (and not the OS package manager) ...is better. I always feel the need to clarify git the software vs. our code repo vs. our mirror on public-inbox.org/git *shrug* > --- a/lib/PublicInbox/XapHelperCxx.pm > +++ b/lib/PublicInbox/XapHelperCxx.pm > @@ -36,7 +36,7 @@ sub xap_cfg (@) { > seek($err, 0, SEEK_SET) or die "seek: $!"; > $err = do { local $/; <$err> }; > die < -@$cmd failed: Xapian devlopment files missing? (\$?=$?) > +@$cmd failed: Xapian development files missing? (\$?=$?) Yup, I also just noticed that on a different branch I'm been working on.