unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] t/imap_searchqp.t: retry bad query test on failure
@ 2023-10-10 10:42 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2023-10-10 10:42 UTC (permalink / raw)
  To: meta

I really don't understand why this fails, sometimes; but it does.
---
 t/imap_searchqp.t | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/t/imap_searchqp.t b/t/imap_searchqp.t
index 968d4329..ff1b4535 100644
--- a/t/imap_searchqp.t
+++ b/t/imap_searchqp.t
@@ -28,12 +28,15 @@ $q = $parse->(qq{CHARSET UTF-8 From b});
 is($q->{xap}, 'f:"b"', 'charset handled');
 $q = $parse->(qq{CHARSET WTF-8 From b});
 like($q, qr/\ANO \[/, 'bad charset rejected');
-{
+
+for my $x ('', ' (try #2)') {
 	open my $fh, '>:scalar', \(my $buf = '') or die;
 	local *STDERR = $fh;
 	$q = $parse->(qq{CHARSET});
-	is($buf, '', 'nothing spewed to STDERR on bad query');
+	last if is($buf, '', "nothing spewed to STDERR on bad query$x");
+	diag 'FIXME: above fails mysteriously sometimes, so we try again...';
 }
+
 like($q, qr/\ABAD /, 'bad charset rejected');
 
 $q = $parse->(qq{HEADER CC B (SENTBEFORE 2-Oct-1993)});

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-10-10 10:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-10 10:42 [PATCH] t/imap_searchqp.t: retry bad query test on failure Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).