unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] makefile: symlink-install: do not depend on realpath
@ 2023-10-04 17:46 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2023-10-04 17:46 UTC (permalink / raw)
  To: meta

For the Makefile, we can use $(PWD) make macro from make(1posix)
as POSIX requires all environment variables be accessible as
macros, and $PWD is a standard sh(1) environment variable.

lei.sh must quiet the stderr of realpath before falling back to
readlink(1) which is available on NetBSD.
---
 Makefile.PL | 2 +-
 lei.sh      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.PL b/Makefile.PL
index 8bd39e6c..38e030f5 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -264,7 +264,7 @@ prefix = \$(HOME)
 bindir = \$(prefix)/bin
 symlink-install : lib/PublicInbox.pm
 	mkdir -p \$(bindir)
-	lei=\$\$(realpath lei.sh) && cd \$(bindir) && \\
+	lei="\$(PWD)/lei.sh" && cd \$(bindir) && \\
 	for x in \$(EXE_FILES); do \\
 		ln -sf "\$\$lei" \$\$(basename "\$\$x"); \\
 	done
diff --git a/lei.sh b/lei.sh
index f1510a73..afb03f3e 100755
--- a/lei.sh
+++ b/lei.sh
@@ -1,7 +1,7 @@
 #!/bin/sh -e
 # symlink this file to a directory in PATH to run lei (or anything in script/*)
 # without needing perms to install globally.  Used by "make symlink-install"
-p=$(realpath "$0" || readlink "$0") # neither is POSIX, but common
+p=$(realpath "$0" 2>/dev/null || readlink "$0") # neither is POSIX, but common
 p=$(dirname "$p") c=$(basename "$0") # both are POSIX
 exec ${PERL-perl} -w -I"$p"/lib "$p"/script/"${c%.sh}" "$@"
 : this script is too short to copyright

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-10-04 17:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-04 17:46 [PATCH] makefile: symlink-install: do not depend on realpath Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).