From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] viewvcs: avoid uninitialized var on unusable filenames
Date: Sat, 8 Apr 2023 20:08:36 +0000 [thread overview]
Message-ID: <20230408200836.1345281-1-e@80x24.org> (raw)
This happens if somebody uses a bogus filename like `.' for the
`b=' parameter (e.g. GET `$REPO/$OID/?b=.').
---
lib/PublicInbox/ViewVCS.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 964b7345..3ab39c8b 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -514,7 +514,7 @@ sub solve_result {
return show_other($ctx, $res) if $type ne 'blob';
my $fn = $di->{path_b} // $hints->{path_b};
my $paths = $ctx->{-paths} //= do {
- my $path = to_filename($fn // 'blob');
+ my $path = to_filename($fn // 'blob') // 'blob';
my $raw_more = qq[(<a\nhref="$path">raw</a>)];
my @def;
reply other threads:[~2023-04-08 20:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230408200836.1345281-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).