From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 7509C1F452 for ; Sat, 8 Apr 2023 20:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1680984516; bh=oAs2HOzPE6XmNXZZ59fwjXx+ApA9mGg/REm2TDgO78A=; h=From:To:Subject:Date:From; b=5raZs/mVhuNgxoAC9ePHGwZbdkxuf8yl8/2xxBv3OOgKAzMrWgizfBD4y7GYS6lB7 EG/Dg85Oc9uXJEVDv2J6oBIgmkcbz6dIcSIC7PuhSAk7R9PK9E/XnQ4S724Mw3Xor6 DtfTllBiJ4d33Rut9ZURtWng3wjB4B9/GDBnr2qk= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] viewvcs: avoid uninitialized var on unusable filenames Date: Sat, 8 Apr 2023 20:08:36 +0000 Message-Id: <20230408200836.1345281-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This happens if somebody uses a bogus filename like `.' for the `b=' parameter (e.g. GET `$REPO/$OID/?b=.'). --- lib/PublicInbox/ViewVCS.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index 964b7345..3ab39c8b 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -514,7 +514,7 @@ sub solve_result { return show_other($ctx, $res) if $type ne 'blob'; my $fn = $di->{path_b} // $hints->{path_b}; my $paths = $ctx->{-paths} //= do { - my $path = to_filename($fn // 'blob'); + my $path = to_filename($fn // 'blob') // 'blob'; my $raw_more = qq[(raw)]; my @def;