unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] watch: avoid Mail::IMAPClient errors when disconnected
Date: Sun, 26 Mar 2023 10:52:45 +0000	[thread overview]
Message-ID: <20230326105246.2159382-2-e@80x24.org> (raw)
In-Reply-To: <20230326105246.2159382-1-e@80x24.org>

No point in issuing LOGOUT commands and causing Mail::IMAPClient
to spew a giant backtrace when we're unconnected.
---
 lib/PublicInbox/Watch.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Watch.pm b/lib/PublicInbox/Watch.pm
index 8482100c..810fb63b 100644
--- a/lib/PublicInbox/Watch.pm
+++ b/lib/PublicInbox/Watch.pm
@@ -254,9 +254,10 @@ sub quit {
 	%{$self->{opendirs}} = ();
 	_done_for_now($self);
 	quit_done($self);
-	if (my $idle_mic = $self->{idle_mic}) {
+	if (my $idle_mic = delete $self->{idle_mic}) {
+		return unless $idle_mic->IsConnected && $idle_mic->Socket;
 		eval { $idle_mic->done };
-		if ($@) {
+		if ($@ && $idle_mic->IsConnected && $idle_mic->Socket) {
 			warn "IDLE DONE error: $@\n";
 			eval { $idle_mic->disconnect };
 			warn "IDLE LOGOUT error: $@\n" if $@;

  reply	other threads:[~2023-03-26 10:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-26 10:52 [PATCH 0/2] public-inbox-watch fixes Eric Wong
2023-03-26 10:52 ` Eric Wong [this message]
2023-03-26 10:52 ` [PATCH 2/2] watch: do not recreate signalfd on SIGHUP Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230326105246.2159382-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).