From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 158DE1F428 for ; Sun, 26 Mar 2023 10:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1679827967; bh=iBbEQByD9T7468NCjlt8FvBFhHbK6LuU1MxVcbJ8jrA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=5U7+ep2XiG72j9LcAnlOHvh0g2IdfqU35vqmkxaFwKRqfFaFgmRHxKZWC1VLVYGkJ SQOoT1x8zlnczr2PqR7+GWFP/w0E/vi8cG4/zF+wO/MEXFb85xKVdIN6b53FQ6vEG2 6o8RrhnS0Sm76VS0FkTr4vtt4SvnMOqt6q+y/PBQ= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/2] watch: avoid Mail::IMAPClient errors when disconnected Date: Sun, 26 Mar 2023 10:52:45 +0000 Message-Id: <20230326105246.2159382-2-e@80x24.org> In-Reply-To: <20230326105246.2159382-1-e@80x24.org> References: <20230326105246.2159382-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: No point in issuing LOGOUT commands and causing Mail::IMAPClient to spew a giant backtrace when we're unconnected. --- lib/PublicInbox/Watch.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/Watch.pm b/lib/PublicInbox/Watch.pm index 8482100c..810fb63b 100644 --- a/lib/PublicInbox/Watch.pm +++ b/lib/PublicInbox/Watch.pm @@ -254,9 +254,10 @@ sub quit { %{$self->{opendirs}} = (); _done_for_now($self); quit_done($self); - if (my $idle_mic = $self->{idle_mic}) { + if (my $idle_mic = delete $self->{idle_mic}) { + return unless $idle_mic->IsConnected && $idle_mic->Socket; eval { $idle_mic->done }; - if ($@) { + if ($@ && $idle_mic->IsConnected && $idle_mic->Socket) { warn "IDLE DONE error: $@\n"; eval { $idle_mic->disconnect }; warn "IDLE LOGOUT error: $@\n" if $@;