unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 1/2] git: use --batch-command in git 2.36+ to save processes
Date: Thu, 9 Feb 2023 01:29:32 +0000	[thread overview]
Message-ID: <20230209012932.M934961@dcvr> (raw)
In-Reply-To: <20230126093257.1058494-2-e@80x24.org>

--batch-command seems to be causing problems with ViewVCS.
I've been noticing "Failed to retrieve generated blob" errors in
syslog.  It doesn't affect any mail retrievals AFAIK, since
those are (currently) separate processes and those are contents-only
(no info header-only retrievals)

Not sure what's going on, yet, but using this to gather
more data:

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 5fd46610..0fb77c06 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -549,7 +549,8 @@ sub show_blob { # git->cat_async callback
 	my ($blob, $oid, $type, $size, $ctx) = @_;
 	if (!$blob) {
 		my $e = "Failed to retrieve generated blob ($oid)";
-		warn "$e ($ctx->{git}->{git_dir}) type=$type";
+		warn("$e ($ctx->{git}->{git_dir}) type=$type ",
+			"u=$ctx->{env}->{REQUEST_URI}".Carp::longmess()."\n");
 		return html_page($ctx, 500, "<pre><b>$e</b></pre>".dbg_log($ctx))
 	}
 

  parent reply	other threads:[~2023-02-09  1:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26  9:32 [PATCH 0/2] use `git cat-file --batch-command' if available Eric Wong
2023-01-26  9:32 ` [PATCH 1/2] git: use --batch-command in git 2.36+ to save processes Eric Wong
2023-01-27  8:14   ` Eric Wong
2023-01-27  8:17     ` Eric Wong
2023-02-09  1:29   ` Eric Wong [this message]
2023-02-20  8:19     ` [PATCH] git_async_cat: don't mis-abort replaced process Eric Wong
2023-01-26  9:32 ` [PATCH 2/2] git: drop needless checks for old git Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209012932.M934961@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).