From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id F13F71F5A0;
	Thu,  9 Feb 2023 01:29:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1675906173;
	bh=4nCS/njyOHYeuWzY47rKBznpKv+M9/ChrhRDalckieY=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=YBlURG4XmQ7UTpm2KLLWE2CLA+Go7GH7T8QSmTmwnpLlTBhClmDlINE9ku1K4F2kD
	 0vz6cOSy2OP0nKIdjO2eV1HB/M29pZGDkbeaCKdjezJFq7C8ToZo4UAdQ3lvnRH74J
	 GOH0EHrEkWCl8tJJY9rgEZMTZTldO9LKwOV/V/us=
Date: Thu, 9 Feb 2023 01:29:32 +0000
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 1/2] git: use --batch-command in git 2.36+ to save
 processes
Message-ID: <20230209012932.M934961@dcvr>
References: <20230126093257.1058494-1-e@80x24.org>
 <20230126093257.1058494-2-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230126093257.1058494-2-e@80x24.org>
List-Id: <meta.public-inbox.org>

--batch-command seems to be causing problems with ViewVCS.
I've been noticing "Failed to retrieve generated blob" errors in
syslog.  It doesn't affect any mail retrievals AFAIK, since
those are (currently) separate processes and those are contents-only
(no info header-only retrievals)

Not sure what's going on, yet, but using this to gather
more data:

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 5fd46610..0fb77c06 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -549,7 +549,8 @@ sub show_blob { # git->cat_async callback
 	my ($blob, $oid, $type, $size, $ctx) = @_;
 	if (!$blob) {
 		my $e = "Failed to retrieve generated blob ($oid)";
-		warn "$e ($ctx->{git}->{git_dir}) type=$type";
+		warn("$e ($ctx->{git}->{git_dir}) type=$type ",
+			"u=$ctx->{env}->{REQUEST_URI}".Carp::longmess()."\n");
 		return html_page($ctx, 500, "<pre><b>$e</b></pre>".dbg_log($ctx))
 	}