unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] admin: index_inbox: drop unnecessary check
Date: Fri, 30 Jul 2021 12:18:54 +0000	[thread overview]
Message-ID: <20210730121855.24242-2-e@80x24.org> (raw)
In-Reply-To: <20210730121855.24242-1-e@80x24.org>

No callers pass an unblessed pathname to index_inbox,
only Inbox object refs.
---
 lib/PublicInbox/Admin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Admin.pm b/lib/PublicInbox/Admin.pm
index eb38dd8f..d5f867a2 100644
--- a/lib/PublicInbox/Admin.pm
+++ b/lib/PublicInbox/Admin.pm
@@ -247,7 +247,7 @@ sub index_inbox {
 		return if PublicInbox::Eml::warn_ignore(@_);
 		warn($idx->{current_info}, ': ', @_);
 	};
-	if (ref($ibx) && $ibx->version == 2) {
+	if ($ibx->version == 2) {
 		eval { require PublicInbox::V2Writable };
 		die "v2 requirements not met: $@\n" if $@;
 		$ibx->{-creat_opt}->{nproc} = $jobs;

  reply	other threads:[~2021-07-30 12:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 12:18 [PATCH 0/2] extindex admin updates Eric Wong
2021-07-30 12:18 ` Eric Wong [this message]
2021-07-30 12:18 ` [PATCH 2/2] extindex: -xcpdb and -compact support Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210730121855.24242-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).