From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id ECABB1F8C7 for ; Fri, 30 Jul 2021 12:18:55 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/2] admin: index_inbox: drop unnecessary check Date: Fri, 30 Jul 2021 12:18:54 +0000 Message-Id: <20210730121855.24242-2-e@80x24.org> In-Reply-To: <20210730121855.24242-1-e@80x24.org> References: <20210730121855.24242-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: No callers pass an unblessed pathname to index_inbox, only Inbox object refs. --- lib/PublicInbox/Admin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Admin.pm b/lib/PublicInbox/Admin.pm index eb38dd8f..d5f867a2 100644 --- a/lib/PublicInbox/Admin.pm +++ b/lib/PublicInbox/Admin.pm @@ -247,7 +247,7 @@ sub index_inbox { return if PublicInbox::Eml::warn_ignore(@_); warn($idx->{current_info}, ': ', @_); }; - if (ref($ibx) && $ibx->version == 2) { + if ($ibx->version == 2) { eval { require PublicInbox::V2Writable }; die "v2 requirements not met: $@\n" if $@; $ibx->{-creat_opt}->{nproc} = $jobs;