* [PATCH] lei sucks: don't warn or error out on missing dependencies
@ 2021-06-20 4:33 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-06-20 4:33 UTC (permalink / raw)
To: meta
%INC can hold undef. This can be hit on a Linux machine missing
Linux::Inotify2. Loading PublicInbox::KQNotify is attempted and
PublicInbox/KQNotify.pm always exists, causing the `undef' entry
in %INC when it fails to load IO::KQueue.
$ perl -MData::Dumper -I lib \
-E 'eval { require PublicInbox::KQNotify }; say Dumper(\%INC)'
---
lib/PublicInbox/LeiSucks.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/LeiSucks.pm b/lib/PublicInbox/LeiSucks.pm
index a71158f3..3e945d0b 100644
--- a/lib/PublicInbox/LeiSucks.pm
+++ b/lib/PublicInbox/LeiSucks.pm
@@ -55,7 +55,7 @@ sub lei_sucks {
my $dig = Digest::SHA->new(1);
push @out, "public-inbox blob OIDs of loaded features:\n";
for my $m (grep(m{^PublicInbox/}, sort keys %INC)) {
- my $f = $INC{$m};
+ my $f = $INC{$m} // next; # lazy require failed (missing dep)
$dig->add('blob '.(-s $f)."\0");
$dig->addfile($f);
push @out, ' '.$dig->hexdigest.' '.$m."\n";
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-20 4:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-20 4:33 [PATCH] lei sucks: don't warn or error out on missing dependencies Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).