unofficial mirror of meta@public-inbox.org
 help / color / Atom feed
* [PATCH] t/run: show unexpected output lines in logs
@ 2020-06-29  0:30 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-06-29  0:30 UTC (permalink / raw)
  To: meta

This will help us catch warnings in new code and notice
inadvertantly skipped tests.
---
 t/run.perl | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/t/run.perl b/t/run.perl
index 017ca3e82c7..b1a0d2fe154 100755
--- a/t/run.perl
+++ b/t/run.perl
@@ -61,7 +61,19 @@ our ($worker, $worker_test);
 sub test_status () {
 	$? = 255 if $? == 0 && !$tb->is_passing;
 	my $status = $? ? 'not ok' : 'ok';
-	print OLDOUT "$status $worker_test\n" if $log_suffix ne '';
+	chdir($cwd) or DIE "chdir($cwd): $!";
+	if ($log_suffix ne '') {
+		my $log = $worker_test;
+		$log =~ s/\.t\z/$log_suffix/;
+		if (open my $fh, '<', $log) {
+			my @not_ok = grep(!/^(?:ok |[ \t]*#)/ms, <$fh>);
+			pop @not_ok if $not_ok[-1] =~ /^[0-9]+\.\.[0-9]+$/;
+			print OLDERR map { "# $log: $_" } @not_ok;
+		} else {
+			print OLDERR "could not open: $log: $!\n";
+		}
+		print OLDOUT "$status $worker_test\n";
+	}
 }
 
 # Test::Builder or Test2::Hub may call exit() from plan(skip_all => ...)
@@ -112,7 +124,6 @@ my $start_worker = sub {
 			my $t = unpack('I', $buf);
 			run_test($todo->[$t]);
 			$tb->reset;
-			chdir($cwd) or DIE "chdir: $!";
 		}
 		kill 'USR1', $producer if !$eof; # sets $eof in $producer
 		DIE join('', map { "E: $_\n" } @err) if @err;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29  0:30 [PATCH] t/run: show unexpected output lines in logs Eric Wong

unofficial mirror of meta@public-inbox.org

Archives are clonable: git clone --mirror https://yhetil.org/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.public-inbox.meta
	nntp://news.public-inbox.org/inbox.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git