From: Ricardo Wurmus <rekado@elephly.net>
To: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>, gwl-devel@gnu.org
Subject: Re: Processing large amounts of files
Date: Tue, 26 Mar 2024 22:30:45 +0100 [thread overview]
Message-ID: <87v858brxq.fsf@elephly.net> (raw)
In-Reply-To: <877chvehuu.fsf@elephly.net>
Ricardo Wurmus <rekado@elephly.net> writes:
> Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> writes:
>
>> For comparison:
>> time cat /tmp/meow/{0..7769}
>> […]
>>
>> real 0m0,144s
>> user 0m0,049s
>> sys 0m0,094s
>>
>> It takes GWL 6 times longer to compute the workflow than to create the
>> inputs in Guile, and 600 times longer than to actually execute the
>> shell command. I think there is room for improvement :)
>
> GWL checks if all input files exist before running the command. Part of
> the difference you see here (takes about 2 seconds on my laptop) is GWL
> running FILE-EXISTS? on 7769 files. This happens in prepare-inputs; its
> purpose:
>
> "Ensure that all files in the INPUTS-MAP alist exist and are linked to
> the expected locations. Pick unspecified inputs from the environment.
> Return either the INPUTS-MAP alist with any additionally used input
> file names added, or raise a condition containing the list of missing
> files."
>
> Another significant delay is introduced by the cache mechanism, which
> computes a unique prefix based on the contents of all input files. It's
> not unexpected that this will take a little while, but it's not great
> either.
With commit f4442e409cf05d0c7cc4d6a251626d22efaffe8c it's a little
faster. We used a whole lot of alists, and this becomes slow when there
are thousands of inputs. We're now using hash tables.
--
Ricardo
next prev parent reply other threads:[~2024-03-26 21:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2010bdb88116d64da3650b06e58979518b2c7277.camel@ist.tugraz.at>
2024-03-21 14:34 ` Processing large amounts of files Ricardo Wurmus
2024-03-25 7:42 ` Liliana Marie Prikler
2024-03-25 9:25 ` Ricardo Wurmus
2024-03-25 10:42 ` Ricardo Wurmus
2024-03-21 15:03 ` Ricardo Wurmus
2024-03-21 15:33 ` Liliana Marie Prikler
2024-03-26 21:30 ` Ricardo Wurmus [this message]
2024-03-27 7:10 ` Liliana Marie Prikler
2024-03-27 9:58 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.guixwl.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v858brxq.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=gwl-devel@gnu.org \
--cc=liliana.prikler@ist.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).