From: raingloom via Guix-patches via <guix-patches@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: "37284-done@debbugs.gnu.org" <37284-done@debbugs.gnu.org>
Subject: [bug#37284] [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner)
Date: Sun, 08 Sep 2019 09:25:30 +0000 [thread overview]
Message-ID: <z0fzDYR5B8kf6z0zwtMeoxvnsVBa2Hw-eur3Uth26a3Tp4AD2bc4LBtkm2I7obhspf87g0O_d6g7XML2BcnbdB51TRD_-II1e3gETzI00z0=@protonmail.com> (raw)
In-Reply-To: <871rwrm9jj.fsf_-_@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
Yep, looks like I _thought_ I used `git commit -a --amend` but I forgot the -a. *facepalm*
Here is what I actually wanted to send.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, September 8, 2019 9:17 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> raingloom raingloom@protonmail.com writes:
>
> > Updated again. Is sending it as an attachment fine?
>
> Well, oddly, it seems that your update addressed only one of my
> suggestions. So, I applied your patch with the following changes:
>
> - fixed the commit message,
> - added a copyright line,
> - added the (file-name ...) line,
> - split the (sha256 ...) line,
> - re-ordered the inputs,
> - changed case in synopsis,
> - fixed typographic mistakes in the description and the licenses
> comments.
>
> Let me know if something is wrong, in particular the copyright line,
> which I add to guess.
>
> Thank you for your contribution!
>
> Regards,
>
> --
> Nicolas Goaziou
>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-packages-music.scm-fmit-New-variable.patch --]
[-- Type: text/x-patch; name="0001-gnu-packages-music.scm-fmit-New-variable.patch", Size: 3458 bytes --]
From 0bbe19a1d37c981f699d4681e237aadc61089c90 Mon Sep 17 00:00:00 2001
From: raingloom <raingloom@protonmail.com>
Date: Mon, 2 Sep 2019 15:44:15 +0200
Subject: [PATCH] * gnu/packages/music.scm (fmit): New variable.
---
gnu/packages/music.scm | 62 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index d4aaecc1e2..0e0ead5229 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -22,6 +22,7 @@
;;; Copyright © 2019 Gabriel Hondet <gabrielhondet@gmail.com>
;;; Copyright © 2019 Timotej Lazar <timotej.lazar@araneo.si>
;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays@sdf.lonestar.org>
+;;; Copyright © 2019 raingloom <raingloom@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -4483,3 +4484,64 @@ discard bad quality ones.
controller.")
(home-page "https://github.com/charlesfleche/lpd8editor")
(license license:expat)))
+
+(define-public fmit
+ (package
+ (name "fmit")
+ (version "1.2.6")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/gillesdegottex/fmit/")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "03nzkig5mw2rqwhwmg0qvc5cnk9bwh2wp13jh0mdrr935w0587mz"))))
+ (build-system gnu-build-system)
+ (arguments
+ '(#:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ (add-before 'build 'qmake
+ (lambda _
+ (let ((out (assoc-ref %outputs "out")))
+ (invoke "qmake"
+ "fmit.pro"
+ (string-append "PREFIX=" out)
+ (string-append "PREFIXSHORTCUT=" out)
+ "CONFIG+=acs_qt acs_alsa acs_jack acs_portaudio"))))
+ (add-after 'install 'wrap-executable
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (wrap-program (string-append out "/bin/fmit")
+ `("QT_PLUGIN_PATH" ":" prefix
+ ,(map (lambda (label)
+ (string-append (assoc-ref inputs label)
+ "/lib/qt5/plugins"))
+ '("qtbase" "qtmultimedia" "qtsvg")))
+ `("QML2_IMPORT_PATH" ":" prefix
+ ,(map (lambda (label)
+ (string-append (assoc-ref inputs label)
+ "/lib/qt5/qml"))
+ '("qtmultimedia"))))
+ #t))))))
+ (inputs
+ `(("alsa-lib" ,alsa-lib)
+ ("fftw" ,fftw)
+ ("jack" ,jack-1)
+ ("portaudio" ,portaudio)
+ ("qtbase" ,qtbase)
+ ("qtmultimedia" ,qtmultimedia)
+ ("qtsvg" ,qtsvg)))
+ (native-inputs
+ `(("gettext" ,gnu-gettext)
+ ("hicolor-icon-theme" ,hicolor-icon-theme)
+ ("itstool" ,itstool)
+ ("qttools" ,qttools)))
+ (synopsis "Musical instrument tuner")
+ (description "FMIT is a graphical utility for tuning musical instruments,
+with error and volume history, and advanced features.")
+ (home-page "https://gillesdegottex.github.io/fmit/")
+ ;; Most of the code is under GPL2+, but some abstract or helper classes are under LGPL2.1.
+ (license (list license:gpl2+ license:lgpl2.1))))
--
2.23.0
next prev parent reply other threads:[~2019-09-08 9:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 16:16 [bug#37284] [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner) raingloom via Guix-patches via
2019-09-02 17:29 ` Nicolas Goaziou
2019-09-03 1:13 ` raingloom via Guix-patches via
2019-09-04 16:01 ` Nicolas Goaziou
2019-09-07 22:12 ` raingloom via Guix-patches via
2019-09-08 9:17 ` bug#37284: " Nicolas Goaziou
2019-09-08 9:25 ` raingloom via Guix-patches via [this message]
[not found] ` <handler.37284.D37284.156793426311682.notifdone@debbugs.gnu.org>
2019-09-08 9:22 ` [bug#37284] closed (Re: [bug#37284] [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner)) raingloom via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='z0fzDYR5B8kf6z0zwtMeoxvnsVBa2Hw-eur3Uth26a3Tp4AD2bc4LBtkm2I7obhspf87g0O_d6g7XML2BcnbdB51TRD_-II1e3gETzI00z0=@protonmail.com' \
--to=guix-patches@gnu.org \
--cc=37284-done@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.