all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Zheng Junjie via Guix-patches via <guix-patches@gnu.org>
To: 64673@debbugs.gnu.org
Subject: [bug#64673] [PATCH 3/3] gnu: quickjs: Honor the #:tests? flag.
Date: Mon, 17 Jul 2023 12:10:57 +0800	[thread overview]
Message-ID: <tencent_FD05E53E258FB56A9B8BA95859DD7FC73A08@qq.com> (raw)
In-Reply-To: <cover.1689566689.git.873216071@qq.com>

* gnu/packages/javascript.scm (quickjs)[arguments]: Adjust custom
'check phase to honor the #:tests? flag.
---
 gnu/packages/javascript.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/javascript.scm b/gnu/packages/javascript.scm
index b9ee5a93b3..1c37f73d75 100644
--- a/gnu/packages/javascript.scm
+++ b/gnu/packages/javascript.scm
@@ -828,8 +828,9 @@ (define-public quickjs
            #:phases #~(modify-phases %standard-phases
                         (delete 'configure)
                         (replace 'check
-                          (lambda _
-                            (invoke "make" "microbench"))))))
+                          (lambda* (#:key tests? #:allow-other-keys)
+                            (when tests?
+                              (invoke "make" "microbench")))))))
     (home-page "https://bellard.org/quickjs/")
     (synopsis "Small embeddable Javascript engine")
     (description "QuickJS supports the ES2020 specification including modules,
-- 
2.41.0





      parent reply	other threads:[~2023-07-17  4:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1689566689.git.873216071@qq.com>
2023-07-17  4:10 ` [bug#64673] [PATCH 1/3] gnu: quickjs: Fix building on riscv64-linux Zheng Junjie via Guix-patches via
2023-07-17  4:10 ` [bug#64673] [PATCH 2/3] gnu: quickjs: Use G-expressions Zheng Junjie via Guix-patches via
2023-07-17  4:10 ` Zheng Junjie via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_FD05E53E258FB56A9B8BA95859DD7FC73A08@qq.com \
    --to=guix-patches@gnu.org \
    --cc=64673@debbugs.gnu.org \
    --cc=873216071@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.