From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: Mark Meyer <mark@ofosos.org>, 30266@debbugs.gnu.org
Subject: [bug#30266] Add FANN
Date: Sun, 28 Jan 2018 12:13:42 +1000 [thread overview]
Message-ID: <ffeda75e-e2f8-eaf3-8f06-18fc70b1bf85@uq.edu.au> (raw)
In-Reply-To: <1517057739.331219.1250048536.75FA3BFA@webmail.messagingengine.com>
[-- Attachment #1: Type: text/plain, Size: 2785 bytes --]
Hi Mark,
Thanks for the patch.
> +(define-module (gnu packages ai)
> + #:use-module ((guix licenses) #:prefix license:)
> + #:use-module (guix utils)
> + #:use-module (guix download)
> + #:use-module (guix packages)
> + #:use-module (guix build-system cmake)
> + #:use-module (guix git-download)
> + #:use-module (gnu packages))
I think machine-learning.scm would be a good home for this package, so a
new file wouldn't be needed.
> +
> +(define-public libfann
> + (package
> + (name "libfann")
> + (version "d71d54788b")
The last release is 129 commits behind and it has been some time, so I
think you are right - we should package from a git commit.
Usually we package from git using this style though (i.e. reason for not
using the release, use of 'file-name', and a version that includes the
last release followed by '-1.<commit>').
;; There are no recent releases so we package from git.
(let ((commit "da121155a977197cab9fbb15953ca1b40b11eb87"))
(package
(name "newick-utils")
(version (string-append "1.6-1." (string-take commit 8)))
(source (origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/tjunier/newick_utils.git")
(commit commit)))
(file-name (string-append name "-" version "-checkout"))
(sha256
(base32
"1hkw21rq1mwf7xp0rmbb2gqc0i6p11108m69i7mr7xcjl268pxnb"))))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url"https://github.com/libfann/fann.git")
> + (commit version)))
> + (sha256
> + (base32
> + "0ibwpfrjs6q2lijs8slxjgzb2llcl6rk3v2ski4r6215g5jjhg3x"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:tests? #f))
I see from the website:
> Once you have installed the library you can test it out by going to
> the examples directory and type |make runtest|, which will compile the
> examples and run a few of them to test that everything is working.
Is that possible? Ideally, since there are tests it would be good to run
them.
> + (home-page"http://leenissen.dk/fann/wp/")
> + (synopsis "Fast Artificial Neural Network")
> + (description
> + "FANN is a free open source neural network library, which implements
> +multilayer artificial neural networks in C with support for both fully
> +connected and sparsely connected networks.")
> + (license license:lgpl2.1)))
Otherwise LGTM. Can you send an updated patch please?
Thanks, ben
[-- Attachment #2: Type: text/html, Size: 3903 bytes --]
next prev parent reply other threads:[~2018-01-28 2:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 12:55 [bug#30266] Add FANN Mark Meyer
2018-01-28 2:13 ` Ben Woodcroft [this message]
2018-02-01 15:32 ` Mark Meyer
2018-02-02 13:12 ` bug#30266: " Ben Woodcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffeda75e-e2f8-eaf3-8f06-18fc70b1bf85@uq.edu.au \
--to=b.woodcroft@uq.edu.au \
--cc=30266@debbugs.gnu.org \
--cc=mark@ofosos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.