From: Maxime Devos <maximedevos@telenet.be>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 54691@debbugs.gnu.org
Subject: bug#54691: [PATCH 2/5] gnu: Add fortunes-jkirchartz.
Date: Sun, 24 Jul 2022 00:01:31 +0200 [thread overview]
Message-ID: <fb6246a5-e720-a0a4-8b40-2988b45c4cc3@telenet.be> (raw)
In-Reply-To: <f54e21f1eba5365e109cbe39835abee2e2cdbb02.camel@gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 3065 bytes --]
On 23-07-2022 22:53, Liliana Marie Prikler wrote:
> Am Samstag, dem 23.07.2022 um 21:56 +0200 schrieb Maxime Devos:
>> On 23-07-2022 17:11, Liliana Marie Prikler wrote:
>>
>>> + (revision "2022.05.23")) ; Use a date rather than a
>>> number
>> This is a technically a possibility, but currently the convention is
>> to use numbers and the number convention is expected by (guix
>> upstream) and the (not yet merged, needs some finishing touches IIRC)
>> latest-git updater, and AFAIK there hasn't been any discussion on
>> switching to dates.
> In this case I am departing from the usual convention because I think
> calendar versioning is more useful for this type of content.
OK, but Guix seems to have decided on numbering in the past, I don't
think a package patch is a place to change that policy. If you want to
change things to calendar versioning for some kinds of git stuff, this
sounds like something to be discussed and approved or disapproved on
guix-devel@gnu.org, not here.
> Given the issue that lead to this patch at all, I'm not sure if support for
> automatic updates would be a good idea with this package. IMHO, it's a
> feature rather than a bug that you can't accidentally pull a third of
> BSD's offensive database, were it to ever land in this repo.
As mentioned later, "guix refresh -u" != automatic updates. I expect
that a person manually updating the package would prefer the aid of
"guix refresh -u" instead of having to clone the git repo by theirselves
and do "guix hash -r", maybe forget the "-x", then remembering that "-r"
is deprecated then having to look in the manual for --serializer=nix.
> Should I explain this thought more clearly in the package or do automatic updates trump ethical concerns?
Guix does not have automatic updates, it does not decide by itself to
update some packaes without any review. The updaters are only run when
done so manually, e.g. with "guix refresh -u fortunes-jkirchartz". In
that case, as always though it seems to be neglected due to limited
resources currently, the diff between the previous version and the new
version should be verified for malware. There's no X trumps Y here, AFAICT.
Also, if Guix decides on CalVer for some packages, then in the context
of the latest-git updater, the latest-git updater will have to be
modified to support CalVer -- latest-git has no idea about how
individual packages work, so it cannot decide to block updates. As such,
going for CalVer to prevent generic-git from updating (with guix refresh
-u or --with-latest) does not seem robust to me, as it will just be
updated anyway with future improvements to latest-git.
If you want to block updates to some degree for some packages, then you
could look into, say, adding a (updatable? . #false) flag or such for
the 'properties' field or maybe add a comment next to the package
definition to ask people updating the package to look out for
fortunes-mod-style badness.
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-07-23 22:02 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 13:09 bug#54691: fortune-mod propagates various non-nice things Maxime Devos
2022-04-03 17:26 ` Liliana Marie Prikler
2022-04-03 18:12 ` Maxime Devos
2022-04-03 18:41 ` Maxime Devos
2022-04-04 10:41 ` Maxime Devos
2022-07-19 19:20 ` Maxime Devos
2022-07-20 4:31 ` Liliana Marie Prikler
2022-07-20 8:45 ` Maxime Devos
2022-07-20 16:57 ` Liliana Marie Prikler
2022-07-20 18:50 ` Maxime Devos
2022-04-03 18:20 ` Maxime Devos
2022-07-14 1:30 ` Maxim Cournoyer
2022-07-14 13:00 ` Csepp
2022-07-14 14:55 ` Maxim Cournoyer
2022-07-19 18:54 ` Maxime Devos
2022-07-19 19:45 ` Maxime Devos
2022-07-23 15:06 ` bug#54691: [PATCH v2 1/5] gnu: Add daikichi Liliana Marie Prikler
2022-07-23 15:06 ` bug#54691: [PATCH " Liliana Marie Prikler
2022-07-23 15:06 ` bug#54691: [PATCH v3 2/6] " Liliana Marie Prikler
2022-07-23 15:11 ` bug#54691: [PATCH v2 2/5] gnu: Add fortunes-jkirchartz Liliana Marie Prikler
2022-07-23 15:11 ` bug#54691: [PATCH " Liliana Marie Prikler
2022-07-23 19:54 ` Maxime Devos
2022-07-23 20:43 ` Liliana Marie Prikler
2022-07-23 21:41 ` Maxime Devos
2022-07-23 21:52 ` Liliana Marie Prikler
2022-07-23 22:13 ` Maxime Devos
2022-07-23 19:56 ` Maxime Devos
2022-07-23 20:53 ` Liliana Marie Prikler
2022-07-23 22:01 ` Maxime Devos [this message]
2022-07-24 1:09 ` bokr
2022-07-23 15:11 ` bug#54691: [PATCH v3 3/6] " Liliana Marie Prikler
2022-07-23 15:13 ` bug#54691: [PATCH v2 3/5] gnu: Remove fortune-mod Liliana Marie Prikler
2022-08-03 13:43 ` [bug#56599] bug#54691: fortune-mod propagates various non-nice things Ludovic Courtès
2022-08-03 17:09 ` Liliana Marie Prikler
2022-08-04 12:23 ` Ludovic Courtès
2022-08-04 15:37 ` [bug#56599] " Tobias Geerinckx-Rice via Guix-patches via
2022-08-04 17:12 ` Liliana Marie Prikler
2022-08-04 19:58 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2022-08-06 23:01 ` [bug#56599] " bokr
2022-08-06 23:05 ` Maxime Devos
2022-08-30 10:22 ` bug#56599: " Liliana Marie Prikler
2022-07-23 15:13 ` bug#54691: [PATCH v3 4/6] gnu: Remove fortune-mod Liliana Marie Prikler
2022-07-23 15:13 ` bug#54691: [PATCH 3/5] " Liliana Marie Prikler
2022-07-23 19:58 ` Maxime Devos
2022-07-23 20:54 ` Liliana Marie Prikler
2022-07-23 15:16 ` bug#54691: [PATCH v3 5/6] gnu: Remove rinutils Liliana Marie Prikler
2022-07-23 15:16 ` bug#54691: [PATCH 4/5] " Liliana Marie Prikler
2022-07-23 15:16 ` bug#54691: [PATCH v2 " Liliana Marie Prikler
2022-07-24 10:33 ` paren--- via Bug reports for GNU Guix
2022-07-24 11:27 ` Liliana Marie Prikler
2022-07-23 15:17 ` bug#54691: [PATCH 5/5] gnu: Remove shlomif-cmake-modules Liliana Marie Prikler
2022-07-23 15:17 ` bug#54691: [PATCH v2 " Liliana Marie Prikler
2022-07-23 15:17 ` bug#54691: [PATCH v3 6/6] " Liliana Marie Prikler
2022-08-13 9:26 ` bug#54691: [PATCH v3 1/6] build-system: copy: Support #:tests? Liliana Marie Prikler
2022-08-28 22:16 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb6246a5-e720-a0a4-8b40-2988b45c4cc3@telenet.be \
--to=maximedevos@telenet.be \
--cc=54691@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.