all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: parouby <contact@parouby.fr>
To: Nils Gillmann <gillmann@infotropique.org>
Cc: 31331@debbugs.gnu.org
Subject: [bug#31331] [PATCH 1/2] gnu: Add bitlbee-discord.
Date: Wed, 2 May 2018 22:21:54 +0200	[thread overview]
Message-ID: <ecb73433-d70d-9aae-739c-c38f9e7a55cb@parouby.fr> (raw)
In-Reply-To: <20180502184112.fi7dtxv2lzz3rxqi@abyayala>

Hi Nils,

On 02/05/2018 20:41, Nils Gillmann wrote:
>> +               (string-append
>> +                "https://github.com/sm00th/bitlbee-discord/"
>> +                "archive/" version ".tar.gz"))
> 
> Nitpick, I would write it like:>  +              (uri
>  +               (string-append "https://github.com/sm00th/bitlbee-discord/"
>  +                              "archive/" version ".tar.gz"))

Yes, it's true, my bad !

>> +         (add-before 'configure 'bash-path
>> +           (lambda* (#:key inputs outputs #:allow-other-keys)
>> +             (substitute* "configure"
>> +               (("\\$SHELL") (string-append (assoc-ref inputs "bash")
>> +                                            "/bin/sh")))))
> 
> Is the configure.ac in this case special, or why doesn't it pick our SHELL
> that is already in the environment of the build chroot?

In this case, without modification the configure try to run '/bin/bash'
and don't care about 'SHELL' environment variable.
I don't found any other way. Any idea ?

>> +    (native-inputs `(("pkg-config" ,pkg-config)
>> +                     ("autoconf" ,autoconf)
>> +                     ("automake" ,automake)
>> +                     ("texinfo" ,texinfo)
>> +                     ("libtool" ,libtool)
>> +                     ("bitlbee" ,bitlbee)
> 
> Does the buildsystem of bitlbee-discord check for bitlbee, or why is this required?

Yes it's need bitlbee lib and header for compilation (just like
bitlbee-dev debian package).

Thanks,
--
Pierre-Antoine

  reply	other threads:[~2018-05-02 20:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 12:05 [bug#31331] [PATCH 1/2] gnu: Add bitlbee-discord Pierre-Antoine Rouby
2018-05-01 17:38 ` [bug#31331] [PATCH 2/2] gnu: services: bitlbee: Add plugins Pierre-Antoine Rouby
2018-05-07  9:41   ` Ludovic Courtès
2018-05-10 14:29     ` Pierre-Antoine Rouby
2018-05-10 14:37       ` Pierre-Antoine Rouby
2018-05-10 20:29         ` bug#31331: " Ludovic Courtès
2018-05-02 18:41 ` [bug#31331] [PATCH 1/2] gnu: Add bitlbee-discord Nils Gillmann
2018-05-02 20:21   ` parouby [this message]
2018-05-02 20:30     ` Nils Gillmann
2018-05-05 15:57       ` Pierre-Antoine Rouby
2018-05-07  9:49         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecb73433-d70d-9aae-739c-c38f9e7a55cb@parouby.fr \
    --to=contact@parouby.fr \
    --cc=31331@debbugs.gnu.org \
    --cc=gillmann@infotropique.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.