From: Raghav Gururajan <rg@raghavgururajan.name>
To: Leo Prikler <leo.prikler@student.tugraz.at>, 45954@debbugs.gnu.org
Subject: [bug#45954] Telegram-CLI (v7/v8)
Date: Tue, 2 Feb 2021 21:41:14 -0500 [thread overview]
Message-ID: <e75a5d6f-c63a-2a37-3534-893a2bff12ea@raghavgururajan.name> (raw)
In-Reply-To: <aacccd6940385c6c31771e118e530beaf76f9012.camel@student.tugraz.at>
[-- Attachment #1.1: Type: text/plain, Size: 2406 bytes --]
Hi Leo!
> Anything particularly worth noting?
Not sure. But based on commit messages, it seems lot of bug fixes.
>>> Please stop trying to use this as a snippet to mean "the root of
>>> the
>>> source and build directory". It is extremely obscure and people
>>> are
>>> already using "../source" just fine. (Just do an rgrep if you
>>> aren't
>>> convinced.)
>>
>> Fixed in v8.
> "Fixed". While it is true, that you're no longer using getenv, binding
> source for string-append later on is not a particularly elegant
> solution either.
>
>>>> Hmm. I tried but couldn't come up with a way to do it like that.
>>>> :(
>>> You can still try harder for v8 ;)
>>
>> I tried different ways but the arguments key-words between gnu and
>> copy
>> differ a lot. I am unable use key-words from both build systems at
>> the
>> same time. Like using #:configure-flags (from gnu) and #:install
>> (from
>> copy).
> Use something along the lines of
> (replace 'install
> (lambda args
> (apply (assoc-ref copy:%standard-phases 'install)
> #:install-plan <your install plan>
> args)))
> Phases should be written in a way, that gratuitous arguments will not
> be read, but passing it in arguments through the package-arguments
> fields remains tricky. Though even if it were possible, the snippet
> above has better locality.
>
>> Also, I spent significant amount time to come up the phase I have. So
>> if
>> there are no critical issues, I would like to keep it as-is. :-)
> I personally regard readability as a severe issue in this case. Of
> course there would be ways of doing this without invoking copy-build-
> system, but in my personal opinion an install plan would likely be the
> most concise here.
>
> For instance instead of using string-append source everywhere, you
> could just use a directory excursion. But more importantly, why is it,
> that all of the stuff you're installing is located in the source
> directory? Do you even build anything that ends up in the
> installation? Would it make more sense to have #:out-of-source? #f?
>
> In tgl, you use several directory excursions when arguably only one
> would be needed. Try to simplify your install process, so that you
> need to bind as few variables as possible.
Agreed. I have updated the pack-def in v9. :-)
Regards,
RG.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2021-02-03 2:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 9:16 [bug#45954] Telegram-CLI Raghav Gururajan
2021-01-19 15:08 ` [bug#45954] Telegram-CLI (v2) Raghav Gururajan
2021-01-20 10:44 ` [bug#45954] Telegram-CLI (v3) Raghav Gururajan
2021-01-22 4:44 ` [bug#45954] Telegram-CLI (v4) Raghav Gururajan
2021-01-28 1:00 ` [bug#45954] Telegram-CLI (v5) Raghav Gururajan
2021-01-31 19:46 ` [bug#45954] Telegram-CLI (v6) Raghav Gururajan
2021-02-01 8:30 ` Leo Prikler
2021-02-01 22:18 ` Raghav Gururajan
2021-02-01 22:08 ` [bug#45954] Telegram-CLI (v7) Raghav Gururajan
2021-02-01 22:39 ` Leo Prikler
2021-02-02 2:33 ` Raghav Gururajan
2021-02-02 9:50 ` [bug#45954] Telegram-CLI (v7/v8) Leo Prikler
2021-02-03 2:41 ` Raghav Gururajan [this message]
2021-02-02 2:25 ` [bug#45954] Telegram-CLI (v8) Raghav Gururajan
2021-02-03 1:56 ` [bug#45954] Telegram-CLI (v9) Raghav Gururajan
2021-02-03 8:16 ` Leo Prikler
2021-02-03 17:52 ` Raghav Gururajan
2021-02-03 17:50 ` [bug#45954] Telegram-CLI (v10) Raghav Gururajan
2021-02-03 18:18 ` bug#45954: " Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e75a5d6f-c63a-2a37-3534-893a2bff12ea@raghavgururajan.name \
--to=rg@raghavgururajan.name \
--cc=45954@debbugs.gnu.org \
--cc=leo.prikler@student.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.