From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: Felix Lechner <felix.lechner@lease-up.com>, 57960@debbugs.gnu.org
Subject: [bug#57960] [PATCH core-updates] gnu: libxkbcommon: Switch to gexp; adjust style.
Date: Wed, 21 Sep 2022 11:03:15 +0200 [thread overview]
Message-ID: <e4ccf0dacc92cf133c2df88f79c8244522a5440e.camel@ist.tugraz.at> (raw)
In-Reply-To: <CAFHYt55gav8sDkg=m-S57TKwNaBVRumnwsj0XXt1KMT5iLPNtA@mail.gmail.com>
Am Dienstag, dem 20.09.2022 um 12:23 -0700 schrieb Felix Lechner:
> + (method url-fetch)
> + (uri (string-append
> + "https://xkbcommon.org/download/libxkbcommon-"
> version
> + ".tar.xz"))
> - (inputs
> - (list libx11
> - libxcb
> - libxml2
> - wayland
> - wayland-protocols
> - xkeyboard-config))
> - (native-inputs
> - (list bison doxygen pkg-config python))
> + (inputs (list libx11
> + libxcb
> + libxml2
> + wayland
> + wayland-protocols
> + xkeyboard-config))
> + (native-inputs (list bison doxygen pkg-config python))
Try to avoid mixing cosmetic and non-cosmetic changes.
> + (list #:configure-flags #~(list (string-append "-Dxkb-config-
> root="
> + (search-input-
> directory
> + %build-inputs
> +
> "share/X11/xkb"))
> + (string-append "-Dx-locale-
> root="
> + (search-input-
> directory
> + %build-inputs
> +
> "share/X11/locale")))))
I am very sure the formatter isn't doing the best job here.
> - (description "Xkbcommon is a library to handle keyboard
> descriptions,
> + (description
> + "Xkbcommon is a library to handle keyboard descriptions,
This change is unnecessary.
Cheers
next prev parent reply other threads:[~2022-09-21 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 19:23 [bug#57960] [PATCH core-updates] gnu: libxkbcommon: Switch to gexp; adjust style Felix Lechner via Guix-patches via
2022-09-21 9:03 ` Liliana Marie Prikler [this message]
2022-09-21 10:16 ` Felix Lechner via Guix-patches via
2022-09-21 11:28 ` Liliana Marie Prikler
2022-10-02 20:43 ` Ludovic Courtès
2022-10-03 6:11 ` Liliana Marie Prikler
2022-10-03 10:02 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4ccf0dacc92cf133c2df88f79c8244522a5440e.camel@ist.tugraz.at \
--to=liliana.prikler@ist.tugraz.at \
--cc=57960@debbugs.gnu.org \
--cc=felix.lechner@lease-up.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.