all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: zimoun <zimon.toutoune@gmail.com>, 52259@debbugs.gnu.org
Subject: [bug#52259] [PATCH 3/3] gnu: trytond: Ensure all modules are found.
Date: Sat, 18 Dec 2021 15:21:07 +0100	[thread overview]
Message-ID: <e4843462-28d0-382f-9ccc-242477c75efe@crazy-compilers.com> (raw)
In-Reply-To: <86mtl338lk.fsf@gmail.com>

Hi,

thanks for the review. I fixed and pushed as 
d4ecdc3328d998c787cbdad6d02e1a74d2fc7ac4


>> Thanks to Maxim Cournoyer, who's code for guix-pythonpath-search-path
>> was the template for guix-trytonpath-search-path.
> The wording appears to me weird, but I am not native.

"whose" is the correct spelling - anyhow I'm not native, too.


>> * gnu/packages/patches/trytond-add-guix_trytond_path.patch: New file.
> Without being picky, why underscore?     ^       ^  Otherwise,

Underscores since this is the name of the functions added. Other patch 
files do the same, "agg-am_c_prototype.patch" - thus I kept the name.


-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |





  reply	other threads:[~2021-12-18 15:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 13:39 [bug#52259] [PATCH 1/3] gnu: python-stdnum: Update to 1.17 Hartmut Goebel
2021-12-03 13:41 ` [bug#52259] [PATCH 2/3] gnu: trytond: Fix import of trytond modules Hartmut Goebel
2021-12-03 13:41 ` [bug#52259] [PATCH 3/3] gnu: trytond: Ensure all modules are found Hartmut Goebel
2021-12-14  8:15   ` zimoun
2021-12-18 14:21     ` Hartmut Goebel [this message]
2021-12-18 15:17       ` zimoun
     [not found] ` <handler.52259.B.16385387683881.ack@debbugs.gnu.org>
2021-12-18 14:21   ` bug#52259: Acknowledgement ([PATCH 1/3] gnu: python-stdnum: Update to 1.17.) Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4843462-28d0-382f-9ccc-242477c75efe@crazy-compilers.com \
    --to=h.goebel@crazy-compilers.com \
    --cc=52259@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.